This repository was archived by the owner on Apr 2, 2024. It is now read-only.
Add math stats precompile interface#3
Closed
adambalogh wants to merge 4 commits intoOpenGradient:mainfrom
Closed
Conversation
added 3 commits
January 23, 2024 21:50
Marblez
reviewed
Jan 24, 2024
src/precompiles/ArbMathStats.sol
Outdated
| * @notice Returns the standard deviation of input | ||
| * @return stddev floating point number represented as an int, with the given number of decimals taken | ||
| */ | ||
| function stdDev(int32[] memory input, uint8 returnDecimals) external returns (int256); |
There was a problem hiding this comment.
This can probably be a view function right? Doesn't modify state or write anything special to DA...etc.
Author
There was a problem hiding this comment.
yep good point! it can even be pure i think
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Precompile implementation: OpenGradient/vanna-nitro#7