Fix code quality issues: exception handling and CORS configuration#112
Open
aydnOktay wants to merge 1 commit intoOpenGradient:mainfrom
Open
Fix code quality issues: exception handling and CORS configuration#112aydnOktay wants to merge 1 commit intoOpenGradient:mainfrom
aydnOktay wants to merge 1 commit intoOpenGradient:mainfrom
Conversation
…ORS configuration - Remove redundant try-except block in service.py that only re-raised exceptions - Remove unused exception variables in auth.py exception handlers - Fix CORS configuration: FastAPI CORSMiddleware doesn't support regex patterns, so list all localhost ports explicitly and add custom middleware for Vercel preview deployments - Add proper docstring to verify_solana_signature function
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR improves code quality by removing unnecessary exception handling, cleaning up unused variables, and fixing CORS configuration. The redundant try-except block in service.py that only re-raised exceptions has been removed, unused exception variables in auth.py have been cleaned up, and CORS configuration has been fixed to properly handle localhost ports and Vercel preview deployments since FastAPI CORSMiddleware doesn't support regex patterns.