Fix exception handler bug and improve error logging#111
Open
aydnOktay wants to merge 1 commit intoOpenGradient:mainfrom
Open
Fix exception handler bug and improve error logging#111aydnOktay wants to merge 1 commit intoOpenGradient:mainfrom
aydnOktay wants to merge 1 commit intoOpenGradient:mainfrom
Conversation
- Fix critical bug in exception handler where request.body() could fail if body was already consumed - Add safe error handling with try-except for request body reading - Limit request body logging to 1KB to prevent logging large payloads and sensitive data - Add request method to error logs for better debugging - Fix grammar error in README: 'a open-source' -> 'an open-source'
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug in the exception handler where reading the request body could fail if it was already consumed. The issue is now handled safely with try-except. Additionally, request body logging is limited to 1KB to prevent security and performance issues, and the request method is added to logs for better debugging. The grammar error in README ("a open-source" -> "an open-source") is also fixed.