Skip to content

[FROM-ML] platform/x86: asus-armoury: gate PPT writes behind active fan curve#52

Open
Ghoul4500 wants to merge 1 commit into
ogc-7.0.yfrom
asus-armoury-gate-ppt
Open

[FROM-ML] platform/x86: asus-armoury: gate PPT writes behind active fan curve#52
Ghoul4500 wants to merge 1 commit into
ogc-7.0.yfrom
asus-armoury-gate-ppt

Conversation

@Ghoul4500
Copy link
Copy Markdown
Member

@Ghoul4500 Ghoul4500 commented May 15, 2026

@Ghoul4500 Ghoul4500 force-pushed the asus-armoury-gate-ppt branch from 5c8183d to b6fcb17 Compare May 15, 2026 15:44
@KyleGospo KyleGospo force-pushed the asus-armoury-gate-ppt branch from b6fcb17 to 1ee713e Compare May 16, 2026 03:32
@KyleGospo KyleGospo changed the base branch from master to ogc-7.0.y May 16, 2026 03:32
@KyleGospo KyleGospo force-pushed the ogc-7.0.y branch 2 times, most recently from a2dc619 to c8b18bb Compare May 18, 2026 19:40
@KyleGospo KyleGospo force-pushed the asus-armoury-gate-ppt branch from 1ee713e to 3d85167 Compare May 18, 2026 21:19
@KyleGospo KyleGospo force-pushed the asus-armoury-gate-ppt branch from 3d85167 to 1303056 Compare May 18, 2026 21:29
@Ghoul4500
Copy link
Copy Markdown
Member Author

Ghoul4500 commented May 19, 2026

I'll bring some slight changes to this according to Mario's review comments on LKML

@Ghoul4500 Ghoul4500 self-assigned this May 19, 2026
@Ghoul4500 Ghoul4500 force-pushed the asus-armoury-gate-ppt branch 2 times, most recently from 003e56d to 58d1f40 Compare May 19, 2026 18:18
…an curve

On models flagged with requires_fan_curve in the DMI power_data table
(30 entries), the BIOS ACPI method SPLX only writes PPT values to the
EC when the fan mode is set to Manual (FANM=4). FANM is set to 4 by
the DEFC method when a custom fan curve is written. Without an active
custom fan curve, the WMI DEVS call returns success but the firmware
silently ignores the PPT value, so userspace observes no effect from
its write.

Gate writes to ASUS_WMI_DEVID_PPT_{PL1_SPL,PL2_SPPT,PL3_FPPT,APU_SPPT,
PLAT_SPPT} on a check of asus_wmi_custom_fan_curve_is_enabled(), and
return -EBUSY with a pr_warn_once() when no fan curve is active on an
affected model. Export the helper from asus-wmi so asus-armoury can
call it across module boundaries.

Signed-off-by: Ahmed Yaseen <yaseen@ghoul.dev>
@Ghoul4500 Ghoul4500 force-pushed the asus-armoury-gate-ppt branch from 58d1f40 to 3a0a399 Compare May 19, 2026 18:20
@Ghoul4500 Ghoul4500 changed the title [FROM-ML] asus-armoury: gate PPT writes on active fan curves [FROM-ML] platform/x86: asus-armoury: gate PPT writes on active fan curves May 19, 2026
@Ghoul4500 Ghoul4500 changed the title [FROM-ML] platform/x86: asus-armoury: gate PPT writes on active fan curves [FROM-ML] platform/x86: asus-armoury: gate PPT writes behind active fan curve May 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants