Skip to content

Conversation

@atravitz
Copy link
Contributor

@atravitz atravitz commented Dec 16, 2025

related to OpenFreeEnergy/pontibus#172

Checklist

  • All new code is appropriately documented (user-facing code must have complete docstrings).
  • Added a news entry, or the changes are not user-facing.
  • Ran pre-commit by making a comment with pre-commit.ci autofix before requesting review.

Manual Tests: these are slow so don't need to be run every commit, only before merging and when relevant changes are made (generally at reviewer-discretion).

Developers certificate of origin

@codecov
Copy link

codecov bot commented Dec 16, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.13%. Comparing base (ea1ae64) to head (3e40b43).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1753      +/-   ##
==========================================
- Coverage   95.39%   93.13%   -2.26%     
==========================================
  Files         189      189              
  Lines       16646    16646              
==========================================
- Hits        15880    15504     -376     
- Misses        766     1142     +376     
Flag Coverage Δ
fast-tests 93.13% <100.00%> (?)
slow-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
Copy link

No API break detected ✅

@atravitz atravitz requested a review from IAlibay December 17, 2025 20:11
@atravitz
Copy link
Contributor Author

I tried to do this in the pyproject.toml config with a module-specific ignore, but that wasn't working and I can't seem to replicate the error locally to look into it more. this should do for now!

@atravitz atravitz marked this pull request as ready for review December 17, 2025 20:12
@mikemhenry
Copy link
Contributor

I tried to do this in the pyproject.toml config with a module-specific ignore, but that wasn't working and I can't seem to replicate the error locally to look into it more. this should do for now!

While a bit redundant, I do like how granular these ignores are so I think it is okay

@mikemhenry mikemhenry merged commit 566d203 into main Dec 17, 2025
12 checks passed
@mikemhenry mikemhenry deleted the ci/mypy_env branch December 17, 2025 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants