-
Notifications
You must be signed in to change notification settings - Fork 35
remove mypy rdkit pin #1753
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove mypy rdkit pin #1753
Conversation
a38eecf to
2c30646
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1753 +/- ##
==========================================
- Coverage 95.39% 93.13% -2.26%
==========================================
Files 189 189
Lines 16646 16646
==========================================
- Hits 15880 15504 -376
- Misses 766 1142 +376
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
2c30646 to
00cc2a3
Compare
|
No API break detected ✅ |
|
I tried to do this in the pyproject.toml config with a module-specific ignore, but that wasn't working and I can't seem to replicate the error locally to look into it more. this should do for now! |
While a bit redundant, I do like how granular these ignores are so I think it is okay |
related to OpenFreeEnergy/pontibus#172
Checklist
newsentry, or the changes are not user-facing.pre-commit.ci autofixbefore requesting review.Manual Tests: these are slow so don't need to be run every commit, only before merging and when relevant changes are made (generally at reviewer-discretion).
Developers certificate of origin