Skip to content

Conversation

@atravitz
Copy link
Contributor

@atravitz atravitz commented Dec 4, 2025

Checklist

  • All new code is appropriately documented (user-facing code must have complete docstrings).
  • Added a news entry, or the changes are not user-facing.
  • Ran pre-commit by making a comment with pre-commit.ci autofix before requesting review.

Manual Tests: these are slow so don't need to be run every commit, only before merging and when relevant changes are made (generally at reviewer-discretion).

Developers certificate of origin

@atravitz atravitz changed the title add autodocs for gathering septop and abfe add docs for gathering septop and abfe Dec 4, 2025
@codecov
Copy link

codecov bot commented Dec 4, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.13%. Comparing base (3e2976c) to head (2a6ea14).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1737      +/-   ##
==========================================
- Coverage   95.36%   93.13%   -2.23%     
==========================================
  Files         189      189              
  Lines       16536    16647     +111     
==========================================
- Hits        15770    15505     -265     
- Misses        766     1142     +376     
Flag Coverage Δ
fast-tests 93.13% <100.00%> (?)
slow-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@atravitz atravitz force-pushed the docs/add_gather_experimental_docs branch from 952cf64 to 0a205a0 Compare December 4, 2025 22:03
@atravitz atravitz marked this pull request as ready for review December 4, 2025 22:04
@atravitz atravitz requested review from IAlibay and mikemhenry and removed request for IAlibay December 4, 2025 22:04
Copy link
Member

@IAlibay IAlibay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just the one thing re: absolute calculations, otherwise lgtm!

@atravitz atravitz force-pushed the docs/add_gather_experimental_docs branch from d5d64c8 to c7fdb2e Compare December 8, 2025 16:01
@atravitz atravitz force-pushed the docs/add_gather_experimental_docs branch from c7fdb2e to 85a72df Compare December 8, 2025 16:03
Co-authored-by: Irfan Alibay <IAlibay@users.noreply.github.com>
"openmmforcefields",
"psutil",
"py3Dmol",
"zstandard",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixes breaking docs upstream

@github-actions
Copy link

github-actions bot commented Dec 8, 2025

No API break detected ✅

Copy link
Member

@IAlibay IAlibay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@atravitz atravitz merged commit a3e1108 into main Dec 8, 2025
13 checks passed
@atravitz atravitz deleted the docs/add_gather_experimental_docs branch December 8, 2025 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants