-
Notifications
You must be signed in to change notification settings - Fork 35
add docs for gathering septop and abfe #1737
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1737 +/- ##
==========================================
- Coverage 95.36% 93.13% -2.23%
==========================================
Files 189 189
Lines 16536 16647 +111
==========================================
- Hits 15770 15505 -265
- Misses 766 1142 +376
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
952cf64 to
0a205a0
Compare
IAlibay
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just the one thing re: absolute calculations, otherwise lgtm!
d5d64c8 to
c7fdb2e
Compare
c7fdb2e to
85a72df
Compare
Co-authored-by: Irfan Alibay <IAlibay@users.noreply.github.com>
| "openmmforcefields", | ||
| "psutil", | ||
| "py3Dmol", | ||
| "zstandard", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixes breaking docs upstream
|
No API break detected ✅ |
IAlibay
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
Checklist
newsentry, or the changes are not user-facing.pre-commit.ci autofixbefore requesting review.Manual Tests: these are slow so don't need to be run every commit, only before merging and when relevant changes are made (generally at reviewer-discretion).
Developers certificate of origin