Skip to content

Conversation

@atravitz
Copy link
Contributor

@atravitz atravitz commented Dec 1, 2025

As seen when testing #1710, ofe-name can be any type (in this case, an int), but we want to cast everything to strings when parsing.

Checklist

  • All new code is appropriately documented (user-facing code must have complete docstrings).
  • Added a news entry, or the changes are not user-facing.
  • Ran pre-commit by making a comment with pre-commit.ci autofix before requesting review.

Manual Tests: these are slow so don't need to be run every commit, only before merging and when relevant changes are made (generally at reviewer-discretion).

Developers certificate of origin

@codecov
Copy link

codecov bot commented Dec 2, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.16%. Comparing base (6a9e7e7) to head (259a812).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1711      +/-   ##
==========================================
- Coverage   95.47%   93.16%   -2.32%     
==========================================
  Files         187      187              
  Lines       16244    16244              
==========================================
- Hits        15509    15133     -376     
- Misses        735     1111     +376     
Flag Coverage Δ
fast-tests 93.16% <100.00%> (?)
slow-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@atravitz atravitz marked this pull request as ready for review December 2, 2025 15:05
@github-actions
Copy link

github-actions bot commented Dec 2, 2025

No API break detected ✅

@atravitz atravitz merged commit 78d0f90 into main Dec 2, 2025
10 of 12 checks passed
@atravitz atravitz deleted the fix/names_are_strings branch December 2, 2025 15:07
@atravitz atravitz mentioned this pull request Dec 4, 2025
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants