Skip to content

fix typo in bandwidth calculation #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pfandzelter merged 1 commit into from
Jan 13, 2025
Merged

fix typo in bandwidth calculation #37

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions celestial/shell.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -434,7 +434,7 @@
# earth's z axis (eg a vector in the positive z direction)
# EARTH_ROTATION_AXIS = [0, 0, 1]
axis: npt.NDArray[np.float64] = np.asarray([0, 0, 1])
axis = axis / math.sqrt(np.dot(axis, axis))

Check failure on line 437 in celestial/shell.py

View workflow job for this annotation

GitHub Actions / python 

Incompatible types in assignment (expression has type "ndarray[tuple[int, ...], dtype[floating[Any]]]", variable has type "ndarray[tuple[int, ...], dtype[float64]]")  [assignment]
a = math.cos(theta / 2.0)
b, c, d = -axis * math.sin(theta / 2.0)
aa, bb, cc, dd = a * a, b * b, c * c, d * d
Expand Down Expand Up @@ -990,8 +990,8 @@
) # type: ignore
)

path_matrix[i, j]["bandwidth_kbits"] = d
# path_matrix[j, i]["bandwidth_kbits"] = d
path_matrix[i, j]["bandwidth_kbits"] = b
# path_matrix[j, i]["bandwidth_kbits"] = b

@staticmethod
@numba.njit # type: ignore
Expand Down
Loading