Skip to content

Add socket-level DB connection resilience #4855

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
stuartc wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add socket-level DB connection resilience #4855

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0fb3b2b
Add socket-level DB connection resilience
stuartc Jun 15, 2026
a254b07
Document DB connection resilience env vars
stuartc Jun 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,12 @@ and this project adheres to

### Changed

- On Linux, database connections now fail fast when their network path dies
(e.g. a TCP reset during a node-pool upgrade) instead of blocking on a dead
socket for up to ~15 minutes. `DATABASE_TCP_USER_TIMEOUT` (ms) defaults to
`DATABASE_TIMEOUT + 5s`; set it to `0` to restore the previous behaviour. No

@rorymckinley rorymckinley Jun 15, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stuartc The wording here and in DEPLOYMENT.md can be interpreted as "it is ok for this to be set on non-Linux systems as it is a no-op". I have not found any documentation to confirm this, so perhaps it may be best to reword it to indicate that Lightning will not apply this setting on non-Linux hosts, to better align with the code?

effect on non-Linux platforms.
[#4855](https://github.com/OpenFn/lightning/pull/4855)
- Consolidate email format validation onto a single canonical validator (Zod v4
regex) applied uniformly across user creation, credential transfer, and both
collaborator add/invite flows. Fixes a silent inconsistency where
Expand Down
Loading