Draft
Conversation
Remove the hardcoded check that prevented credential selection for @openfn/language-common jobs. Users need raw JSON credentials on common adaptor steps for workflow reusability (e.g., facility-specific config). When creating a new credential from a common adaptor job, default to the "raw" (Raw JSON) schema since common has no dedicated schema file.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4513 +/- ##
==========================================
- Coverage 89.55% 89.54% -0.01%
==========================================
Files 425 425
Lines 20307 20307
==========================================
- Hits 18185 18184 -1
- Misses 2122 2123 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
josephjclark
approved these changes
Mar 9, 2026
Collaborator
josephjclark
left a comment
There was a problem hiding this comment.
Thanks @elias-ba !
Collaborator
|
@elias-ba I have converted this to draft. Waiting for product decision |
Contributor
Author
|
Thank you @midigofrank that's the right thing to do. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes credential support for the
@openfn/language-commonadaptor. Previously, the UI showed "This adaptor does not require credentials" and hid all credential options. We just found out that sometimes users need raw JSON credentials on common adaptor steps.Validation steps
@openfn/language-commonAdditional notes for the reviewer
The edit credential flow is unaffected — when editing, the backend loads the existing credential which already has a valid schema stored.
AI Usage
Pre-submission checklist
/reviewwith Claude Code)OpenFn,:admin,:editor,:viewer)