Skip to content

Monnify#1456

Merged
josephjclark merged 22 commits intomainfrom
monnify
Jan 27, 2026
Merged

Monnify#1456
josephjclark merged 22 commits intomainfrom
monnify

Conversation

@PiusKariuki
Copy link
Copy Markdown
Collaborator

Summary

Create an adaptor for the Monnify API

Fixes #1450

Details

Add technical details of what you've changed (and why).

AI Usage

Please disclose how you've used AI in this work (it's cool, we just want to
know!):

  • Code generation (copilot but not intellisense)
  • Learning or fact checking
  • Strategy / design
  • Optimisation / refactoring
  • Translation / spellchecking / doc gen
  • Other
  • I have not used AI

You can read more details in our
Responsible AI Policy

Review Checklist

Before merging, the reviewer should check the following items:

  • Does the PR do what it claims to do?
  • If this is a new adaptor, added the adaptor on marketing website ?
  • If this PR includes breaking changes, do we need to update any jobs in
    production? Is it safe to release?
  • Are there any unit tests?
  • Is there a changeset associated with this PR? Should there be? Note that
    dev only changes don't need a changeset.
  • Have you ticked a box under AI Usage?

Comment thread packages/monnify/configuration-schema.json Outdated
Comment thread packages/monnify/src/Adaptor.js Outdated
Comment thread packages/monnify/src/Utils.js Outdated
Comment thread packages/monnify/test/Adaptor.test.js Outdated
Comment thread packages/monnify/test/fixtures.json
@martalovescoffee
Copy link
Copy Markdown
Collaborator

  1. @PiusKariuki , can you share sandbox access and give a propper testing guidelines please?

…nses

  Implemented requestWithPagination function to automatically fetch all pages when no pagination params are provided, while respecting explicit pageSize/pageNo parameters when specified. Includes validation for max pageSize of 1000 and comprehensive test coverage.
@PiusKariuki PiusKariuki requested review from hunterachieng and mtuchi and removed request for hunterachieng December 17, 2025 17:59
@PiusKariuki
Copy link
Copy Markdown
Collaborator Author

@mtuchi you can review this at your own time

@PiusKariuki
Copy link
Copy Markdown
Collaborator Author

@hunterachieng could you please review this for me

Comment thread packages/monnify/src/Adaptor.js Outdated
Comment thread packages/monnify/src/Adaptor.js Outdated
Comment thread packages/monnify/src/Utils.js Outdated
Comment thread packages/monnify/test/Adaptor.test.js
Comment thread packages/monnify/src/Adaptor.js
Comment thread packages/monnify/src/Adaptor.js
Comment thread packages/monnify/src/Utils.js Outdated
Comment thread packages/monnify/src/Adaptor.js
Comment thread packages/monnify/src/Adaptor.js Outdated
Comment thread packages/monnify/src/Utils.js Outdated
@PiusKariuki
Copy link
Copy Markdown
Collaborator Author

@hunterachieng could you review this again for me

Comment thread packages/monnify/src/Adaptor.js
Comment thread packages/monnify/test/Adaptor.test.js Outdated
@PiusKariuki
Copy link
Copy Markdown
Collaborator Author

@hunterachieng I have made the corrections

Comment thread packages/monnify/src/Adaptor.js
@josephjclark josephjclark merged commit 31f12ae into main Jan 27, 2026
2 checks passed
@josephjclark josephjclark deleted the monnify branch January 27, 2026 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Closed

Development

Successfully merging this pull request may close these issues.

Moniepoint adaptor

5 participants