Linear Trim Solution: update range calculation when NLinTimes=1 #3156
+10
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When linearizing with a trim solution and NLinTimes=1, the range of the reference outputs was always 0.01. Now it uses the channel value. This could probably be modified further, but for now, it gives a slightly better "range"
deslaughter
approved these changes
Jan 20, 2026
Collaborator
deslaughter
left a comment
deslaughter
left a comment
There was a problem hiding this comment.
This looks like a good idea. Thanks!
Collaborator
|
As a note for the future, this won't apply to OpenFAST 5 because it always uses at least two rotor azimuth positions for linearization with CalcSteady (effectively at least NLintimes = 2) and then only save one of them if NLinTimes = 1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature or improvement description
When linearizing with a trim solution and NLinTimes=1, the range of the reference outputs was always 0.01. Now it uses the channel value. This could probably be modified further, but for now, it gives a slightly better range for the convergence calculation.
Related issue, if one exists
Possibly related to #857, though I don't think this will fix that issue.
Impacted areas of the software
Linearizing with Trim Solution and NLinTimes = 1.
Additional supporting information
Due to the check in #1707 that makes NLinTimes at least 2, this fix won't actually do anything in the current code.
Test results, if applicable
This doesn't affect any current regression tests.