Skip to content

fix: wrap dataset loading in main_process_first to prevent cache race #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Neonkraft merged 2 commits into from
Apr 30, 2026
Merged

fix: wrap dataset loading in main_process_first to prevent cache race #20

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
024c8bd
feat: wrap dataset loading in main_process_first to prevent Lustre ca…
Neonkraft Apr 28, 2026
c36807f
Merge branch 'main' into feat/main-process-first
Neonkraft Apr 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/post_training/methods/dpo.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
from pathlib import Path
from typing import TYPE_CHECKING

from accelerate import PartialState
from trl import DPOConfig, DPOTrainer

from post_training.data.loader import load_and_mix_datasets
Expand Down Expand Up @@ -45,7 +46,8 @@ def build_dpo_trainer(config: PostTrainingConfig, run_dir: Path) -> DPOTrainer:
mc = config.dpo # method-specific config

tokenizer = build_tokenizer(config)
dataset = load_and_mix_datasets(config.data, row_filter=_dpo_row_filter)
with PartialState().main_process_first():
dataset = load_and_mix_datasets(config.data, row_filter=_dpo_row_filter)

dpo_config = DPOConfig(
**build_common_training_kwargs(config, run_dir),
Expand Down
4 changes: 3 additions & 1 deletion src/post_training/methods/sft.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
from pathlib import Path
from typing import TYPE_CHECKING

from accelerate import PartialState
from trl import SFTConfig, SFTTrainer

from post_training.data.loader import load_and_mix_datasets
Expand Down Expand Up @@ -45,7 +46,8 @@ def build_sft_trainer(config: PostTrainingConfig, run_dir: Path) -> SFTTrainer:
mc = config.sft # method-specific config

tokenizer = build_tokenizer(config)
dataset = load_and_mix_datasets(config.data, row_filter=_sft_row_filter)
with PartialState().main_process_first():
dataset = load_and_mix_datasets(config.data, row_filter=_sft_row_filter)

sft_config = SFTConfig(
**build_common_training_kwargs(config, run_dir),
Expand Down
Loading