Skip to content

fix: prevent run directory from being wiped on job requeue #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Neonkraft merged 2 commits into from
Apr 30, 2026
Merged

fix: prevent run directory from being wiped on job requeue #19

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9b86a63
fix: gate run-dir override to submit.py to prevent mid-job wipe
Neonkraft Apr 28, 2026
d49ce41
Merge branch 'main' into fix/run-dir-wipe-race
Neonkraft Apr 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion scripts/submit.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,7 @@ def main() -> None:
prefetch_assets(config)

# Set up the run directory (so the SLURM script can reference it).
run_dir = setup_run_directory(config)
run_dir = setup_run_directory(config, allow_override=True)
logger.info("Run directory: %s", run_dir)

if not confirmed:
Expand Down
11 changes: 8 additions & 3 deletions src/post_training/utils/paths.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ def generate_run_name(config: PostTrainingConfig) -> str:
return get_backend(config.backend).generate_run_name(config, timestamp)


def setup_run_directory(config: PostTrainingConfig) -> Path:
def setup_run_directory(config: PostTrainingConfig, allow_override: bool = False) -> Path:
"""Create the run output directory tree and return the run root.

Directory layout::
Expand All @@ -58,8 +58,13 @@ def setup_run_directory(config: PostTrainingConfig) -> Path:

run_dir = base / run_name

# Handle debug override.
if config.debug.enabled and config.debug.override_existing and run_dir.exists():
# Handle debug override — only when submit.py explicitly opts in.
if (
allow_override
and config.debug.enabled
and config.debug.override_existing
and run_dir.exists()
):
shutil.rmtree(run_dir)

from post_training.backend import get_backend
Expand Down
Loading