fix: drop warmup_ratio in favour of warmup_steps#18
Closed
Neonkraft wants to merge 2 commits into
Closed
Conversation
warmup_ratio (float 0.03) was passed to warmup_steps (int), truncating to 0 and silently disabling warmup entirely. Add a warmup_steps config field (default 0) and forward both fields to TrainingArguments so each reaches the correct parameter.
Removes the separate warmup_ratio field; warmup_steps now accepts a float (interpreted as a ratio by TrainingArguments) or int (absolute steps), matching HuggingFace's own convention. Updates all example configs and the guardrails display row accordingly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Drop
warmup_ratiofromTrainingConfigand makewarmup_stepsafloat. The original bug:warmup_ratio(e.g.0.03) was being forwarded towarmup_steps(anintfield inTrainingArguments), silently truncating to0and disabling warmup entirely. HuggingFaceTrainingArgumentsalready interprets a float value forwarmup_stepsas a ratio, so a singlefloatfield covers both use cases with no special handling needed.Type of change