Skip to content

fix: pass cpus-per-task into container job script #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Neonkraft merged 1 commit into from
Apr 17, 2026
Merged

fix: pass cpus-per-task into container job script #15

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/post_training/slurm/job_llamafactory.sh.jinja
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
#SBATCH --nodes={{ num_nodes }}
#SBATCH --ntasks-per-node=1
#SBATCH --gres=gpu:{{ gpus_per_node }}
#SBATCH --cpus-per-task={{ cpus_per_task }}
{% if cpus_per_gpu is integer and cpus_per_gpu > 0 -%}
#SBATCH --cpus-per-gpu={{ cpus_per_gpu }}
{% endif -%}
Expand Down
1 change: 1 addition & 0 deletions src/post_training/slurm/job_trl_container.sh.jinja
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
#SBATCH --nodes={{ num_nodes }}
#SBATCH --ntasks-per-node=1
#SBATCH --gres=gpu:{{ gpus_per_node }}
#SBATCH --cpus-per-task={{ cpus_per_task }}
{% if cpus_per_gpu is integer and cpus_per_gpu > 0 -%}
#SBATCH --cpus-per-gpu={{ cpus_per_gpu }}
{% endif -%}
Expand Down
2 changes: 2 additions & 0 deletions src/post_training/slurm/launcher.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,6 +109,7 @@ def render_trl_container_slurm_script(
partition=config.slurm.partition,
num_nodes=config.slurm.num_nodes,
gpus_per_node=config.slurm.gpus_per_node,
cpus_per_task=config.slurm.cpus_per_task,
cpus_per_gpu=config.slurm.cpus_per_gpu,
wall_time=config.slurm.wall_time,
signal_time_seconds=config.slurm.signal_time_seconds,
Expand Down Expand Up @@ -156,6 +157,7 @@ def render_llamafactory_slurm_script(
partition=config.slurm.partition,
num_nodes=config.slurm.num_nodes,
gpus_per_node=config.slurm.gpus_per_node,
cpus_per_task=config.slurm.cpus_per_task,
cpus_per_gpu=config.slurm.cpus_per_gpu,
wall_time=config.slurm.wall_time,
signal_time_seconds=config.slurm.signal_time_seconds,
Expand Down
Loading