Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/post_training/config.py
Original file line number Diff line number Diff line change
Expand Up @@ -181,6 +181,7 @@ class SlurmConfig:
"""SLURM job scheduler parameters."""

partition: str = "gpu"
account: str | None = None
qos: str | None = None
num_nodes: int = 1
gpus_per_node: int = 4
Expand Down
3 changes: 3 additions & 0 deletions src/post_training/slurm/job.sh.jinja
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,9 @@

#SBATCH --job-name={{ job_name }}
#SBATCH --partition={{ partition }}
{% if account -%}
#SBATCH --account={{ account }}
{% endif -%}
{% if qos -%}
#SBATCH --qos={{ qos }}
{% endif -%}
Expand Down
3 changes: 3 additions & 0 deletions src/post_training/slurm/job_llamafactory.sh.jinja
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,9 @@

#SBATCH --job-name={{ job_name }}
#SBATCH --partition={{ partition }}
{% if account -%}
#SBATCH --account={{ account }}
{% endif -%}
{% if qos -%}
#SBATCH --qos={{ qos }}
{% endif -%}
Expand Down
3 changes: 3 additions & 0 deletions src/post_training/slurm/job_trl_container.sh.jinja
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,9 @@

#SBATCH --job-name={{ job_name }}
#SBATCH --partition={{ partition }}
{% if account -%}
#SBATCH --account={{ account }}
{% endif -%}
{% if qos -%}
#SBATCH --qos={{ qos }}
{% endif -%}
Expand Down
3 changes: 3 additions & 0 deletions src/post_training/slurm/launcher.py
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,7 @@ def render_trl_slurm_script(
# SLURM parameters
job_name=config.slurm.job_name,
partition=config.slurm.partition,
account=config.slurm.account,
qos=config.slurm.qos,
num_nodes=config.slurm.num_nodes,
gpus_per_node=config.slurm.gpus_per_node,
Expand Down Expand Up @@ -109,6 +110,7 @@ def render_trl_container_slurm_script(
# SLURM parameters
job_name=config.slurm.job_name,
partition=config.slurm.partition,
account=config.slurm.account,
qos=config.slurm.qos,
num_nodes=config.slurm.num_nodes,
gpus_per_node=config.slurm.gpus_per_node,
Expand Down Expand Up @@ -159,6 +161,7 @@ def render_llamafactory_slurm_script(
# SLURM parameters
job_name=config.slurm.job_name,
partition=config.slurm.partition,
account=config.slurm.account,
qos=config.slurm.qos,
num_nodes=config.slurm.num_nodes,
gpus_per_node=config.slurm.gpus_per_node,
Expand Down
77 changes: 71 additions & 6 deletions tests/test_slurm_render.py
Original file line number Diff line number Diff line change
Expand Up @@ -6,18 +6,88 @@
from post_training.slurm.launcher import (
render_llamafactory_slurm_script,
render_trl_container_slurm_script,
render_trl_slurm_script,
)


@pytest.fixture
def config():
cfg = PostTrainingConfig()
cfg.container.image = "/shared/containers/llamafactory.sif"
cfg.container.image = "/shared/containers/trl.sif"
cfg.container.bind_mounts = ["/scratch:/scratch"]
cfg.container.env_file = "/shared/env/cluster.env"
return cfg


# ---------------------------------------------------------------------------
# account field — all three templates
# ---------------------------------------------------------------------------


def test_trl_account_rendered(tmp_path, config):
"""account appears as #SBATCH directive when set."""
config.slurm.account = "my_project"
run_dir = tmp_path / "outputs" / "my-run"
run_dir.mkdir(parents=True)

content = render_trl_slurm_script(config, run_dir, "configs/trl/sft.yaml").read_text()

assert "#SBATCH --account=my_project" in content


def test_trl_account_absent_when_none(tmp_path, config):
"""account directive is suppressed when not set."""
run_dir = tmp_path / "outputs" / "my-run"
run_dir.mkdir(parents=True)

content = render_trl_slurm_script(config, run_dir, "configs/trl/sft.yaml").read_text()

assert "--account" not in content


def test_trl_container_account_rendered(tmp_path, config):
config.slurm.account = "my_project"
run_dir = tmp_path / "outputs" / "my-run"
run_dir.mkdir(parents=True)

content = render_trl_container_slurm_script(config, run_dir, "configs/trl/sft.yaml").read_text()

assert "#SBATCH --account=my_project" in content


def test_trl_container_account_absent_when_none(tmp_path, config):
run_dir = tmp_path / "outputs" / "my-run"
run_dir.mkdir(parents=True)

content = render_trl_container_slurm_script(config, run_dir, "configs/trl/sft.yaml").read_text()

assert "--account" not in content


def test_llamafactory_account_rendered(tmp_path, config):
config.slurm.account = "my_project"
run_dir = tmp_path / "outputs" / "my-run"
run_dir.mkdir(parents=True)

content = render_llamafactory_slurm_script(config, run_dir).read_text()

assert "#SBATCH --account=my_project" in content


def test_llamafactory_account_absent_when_none(tmp_path, config):
run_dir = tmp_path / "outputs" / "my-run"
run_dir.mkdir(parents=True)

content = render_llamafactory_slurm_script(config, run_dir).read_text()

assert "--account" not in content


# ---------------------------------------------------------------------------
# qos / mem fields — LlamaFactory and TRL container templates
# ---------------------------------------------------------------------------


def test_llamafactory_qos_mem_rendered(tmp_path, config):
"""qos and mem appear as #SBATCH directives when set."""
config.slurm.qos = "boost_qos_dbg"
Expand All @@ -42,11 +112,6 @@ def test_llamafactory_qos_mem_absent_when_none(tmp_path, config):
assert "--mem" not in content


# ---------------------------------------------------------------------------
# TRL container template
# ---------------------------------------------------------------------------


def test_trl_container_qos_mem_rendered(tmp_path, config):
"""qos and mem appear as #SBATCH directives when set."""
config.slurm.qos = "boost_qos_dbg"
Expand Down
Loading