Skip to content

add boiler subclasses #2189#2226

Merged
stap-m merged 15 commits intodevfrom
feature-2189-boiler-subclasses-2
Apr 7, 2026
Merged

add boiler subclasses #2189#2226
stap-m merged 15 commits intodevfrom
feature-2189-boiler-subclasses-2

Conversation

@stap-m
Copy link
Copy Markdown
Contributor

@stap-m stap-m commented Apr 1, 2026

Summary of the discussion

based on #2189

  1. Add four subclasses of boiler, based on the combusted fuel. All of them
  • should be a subclass of boiler
  • should have an axiom for the resepective fuel they use
  • need an equivalency axiom stating that it is equivalent to a combustion-based heater that has a participant some fluid (inherited via boiler)
  1. Fix axiom of boiler: uses some fuel istead of uses some fluid

Type of change (CHANGELOG.md)

Add

  • natural gas boiler
  • biomass boiler
  • hydrogen boiler
  • oil boiler

Changed

  • boiler

Workflow checklist

Automation

Closes #2189

PR-Assignee

Reviewer

  • 🐙 Follow the Reviewer Guide
  • 🐙 Provided feedback and show sufficient appreciation for the work done

@stap-m stap-m added this to Issues Apr 1, 2026
@github-actions github-actions bot added oeo-physical changes the oeo-physical module oeo.omn changes the oeo.omn -module labels Apr 1, 2026
@github-project-automation github-project-automation bot moved this to Review in progress in Issues Apr 1, 2026
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 1, 2026

Changed axioms per ontology

Note: Changes in term tracker annotations are not displayed

oeo.omn: 0 changes

Ontology comparison

Left

  • Ontology IRI: https://openenergyplatform.org/ontology/oeo/
  • Version IRI: https://openenergyplatform.org/ontology/oeo/dev/oeo.omn
  • Loaded from: file:/__w/ontology/ontology/./dev/src/ontology/oeo.omn

Right

  • Ontology IRI: https://openenergyplatform.org/ontology/oeo/
  • Version IRI: https://openenergyplatform.org/ontology/oeo/dev/oeo.omn
  • Loaded from: file:/__w/ontology/ontology/src/ontology/oeo.omn

Ontology imports

Ontology annotations

biomass boiler https://openenergyplatform.org/ontology/oeo/OEO_00020470

Added

hydrogen boiler https://openenergyplatform.org/ontology/oeo/OEO_00020469

Added

natural gas boiler https://openenergyplatform.org/ontology/oeo/OEO_00020467

Added

oil boiler https://openenergyplatform.org/ontology/oeo/OEO_00020468

Added

oeo-physical.omn: 18 changes

Ontology comparison

Left

  • Ontology IRI: https://openenergyplatform.org/ontology/oeo/oeo-physical/
  • Version IRI: https://openenergyplatform.org/ontology/oeo/dev/oeo-physical.omn
  • Loaded from: file:/__w/ontology/ontology/./dev/src/ontology/edits/oeo-physical.omn

Right

  • Ontology IRI: https://openenergyplatform.org/ontology/oeo/oeo-physical/
  • Version IRI: https://openenergyplatform.org/ontology/oeo/dev/oeo-physical.omn
  • Loaded from: file:/__w/ontology/ontology/src/ontology/edits/oeo-physical.omn

Ontology imports

Ontology annotations

biomass boiler https://openenergyplatform.org/ontology/oeo/OEO_00020470

Added

boiler https://openenergyplatform.org/ontology/oeo/OEO_00310013

Removed

Added

hydrogen boiler https://openenergyplatform.org/ontology/oeo/OEO_00020469

Added

natural gas boiler https://openenergyplatform.org/ontology/oeo/OEO_00020467

Added

oil boiler https://openenergyplatform.org/ontology/oeo/OEO_00020468

Added

@stap-m stap-m mentioned this pull request Apr 1, 2026
5 tasks
@stap-m
Copy link
Copy Markdown
Contributor Author

stap-m commented Apr 1, 2026

By accident, I pushed the changed from PR #2223 🙈
The changes that belong to this PR have been made to oeo-physical and CHANGELOG

@stap-m stap-m marked this pull request as ready for review April 1, 2026 16:25
@stap-m stap-m requested review from Ludee and f-innatech April 1, 2026 16:26
@stap-m stap-m self-assigned this Apr 1, 2026
@stap-m stap-m requested a review from amanda-wein April 1, 2026 16:27
Copy link
Copy Markdown
Contributor

@amanda-wein amanda-wein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, thanks!

@github-project-automation github-project-automation bot moved this from Review in progress to Reviewer approved in Issues Apr 2, 2026
@stap-m stap-m merged commit f1cad4e into dev Apr 7, 2026
4 checks passed
@github-project-automation github-project-automation bot moved this from Reviewer approved to Done in Issues Apr 7, 2026
@stap-m stap-m deleted the feature-2189-boiler-subclasses-2 branch April 7, 2026 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

oeo.omn changes the oeo.omn -module oeo-physical changes the oeo-physical module

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Add Boiler Subcategories

4 participants