Skip to content

add oeo-idranges.owl #2223#2225

Merged
stap-m merged 5 commits intodevfrom
feature-2223-id-ranges
Apr 14, 2026
Merged

add oeo-idranges.owl #2223#2225
stap-m merged 5 commits intodevfrom
feature-2223-id-ranges

Conversation

@stap-m
Copy link
Copy Markdown
Contributor

@stap-m stap-m commented Mar 30, 2026

Summary of the discussion

Add oeo-idranges.owl

With this file, protege should recognize that there are user settings stored for editing OEO. When opening protege, a small window should appear where you should be able to select your user name. The settings for your user should be automatically updated. This allows to have several user IDs for several ontologies, e.g. OEO, CEPO, MUNO, MHPO etc.

Type of change (CHANGELOG.md)

Add

Workflow checklist

Automation

Closes #2223

PR-Assignee

Reviewer

  • 🐙 Follow the Reviewer Guide
  • 🐙 Provided feedback and show sufficient appreciation for the work done

@stap-m stap-m added this to Issues Mar 30, 2026
@github-project-automation github-project-automation bot moved this to Review in progress in Issues Mar 30, 2026
@stap-m
Copy link
Copy Markdown
Contributor Author

stap-m commented Mar 30, 2026

The CI fails, looks like we need an exception for oeo-idranges.owl in the make file?! @b-gehrke could you take a look please?

@areleu
Copy link
Copy Markdown
Contributor

areleu commented Mar 30, 2026

The CI fails, looks like we need an exception for oeo-idranges.owl in the make file?! @b-gehrke could you take a look please?

Try getting rid of the ## at the beginning of the file, comments in owl are added like this:

<!-- comment -->

or maybe change the extension to .omn, not quite sure if ## is a comment symbol in Manchester Syntax

@areleu
Copy link
Copy Markdown
Contributor

areleu commented Mar 30, 2026

I just noticed it is a special format, not proper owl. Is protege able to read it?

Never mind I checked the one of oberon and robot can read it, something is wrong in the serialization

Update: there was a typo in the file, that was causing the parser to throw an error

@areleu
Copy link
Copy Markdown
Contributor

areleu commented Mar 30, 2026

I think the diff check won't pass for new files, maybe we need to add a case for that

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 31, 2026

Changed axioms per ontology

Note: Changes in term tracker annotations are not displayed

oeo-idranges.owl: 6 changes

Ontology comparison

Left

  • Ontology IRI: https://openenergyplatform.org/ontology/oeo/
  • Version IRI: None
  • Loaded from: file:/__w/ontology/ontology/./dev/src/ontology/oeo-idranges.owl

Right

  • Ontology IRI: https://openenergyplatform.org/ontology/oeo/
  • Version IRI: None
  • Loaded from: file:/__w/ontology/ontology/src/ontology/oeo-idranges.owl

Ontology imports

Ontology annotations

2 http://purl.obolibrary.org/obo/ro/idrange/2

Removed

Added

3 http://purl.obolibrary.org/obo/ro/idrange/3

Removed

Added

7 http://purl.obolibrary.org/obo/ro/idrange/7

Added

integer[>= 420004 , <= 429999]

Added

@b-gehrke
Copy link
Copy Markdown
Contributor

I changed the CI such that if the diff-comment job fails the PR is not blocked anymore. Also, the job now simply skips files that it cannot handle (i.e. if a new file is created, a file is deleted or renamed, etc.)

@stap-m stap-m self-assigned this Mar 31, 2026
@stap-m
Copy link
Copy Markdown
Contributor Author

stap-m commented Mar 31, 2026

Thank you @b-gehrke !!
@areleu I also added you to the list. Could you try out, if it works for you, i.e. checkout the branch and open protege?

@areleu
Copy link
Copy Markdown
Contributor

areleu commented Mar 31, 2026

Thank you @b-gehrke !! @areleu I also added you to the list. Could you try out, if it works for you, i.e. checkout the branch and open protege?

Did you push the changes? Protege is identifying it but is not showing my name.

@stap-m stap-m marked this pull request as ready for review April 1, 2026 08:15
Comment thread src/ontology/oeo-idranges.owl Outdated
@stap-m
Copy link
Copy Markdown
Contributor Author

stap-m commented Apr 7, 2026

Did you push the changes? Protege is identifying it but is not showing my name.

Hm, in my local protege your name appears 2nd in the list. Does the list show up at all when you open or reload the OEO in protege?

@areleu
Copy link
Copy Markdown
Contributor

areleu commented Apr 9, 2026

Did you push the changes? Protege is identifying it but is not showing my name.

Hm, in my local protege your name appears 2nd in the list. Does the list show up at all when you open or reload the OEO in protege?

Now is working!

@stap-m
Copy link
Copy Markdown
Contributor Author

stap-m commented Apr 13, 2026

I updated the wiki instruction:
github.com/OpenEnergyPlatform/ontology/wiki/Numerical-Identifiers

@stap-m stap-m requested review from Ludee and schwarzatoffis April 13, 2026 08:33
@stap-m
Copy link
Copy Markdown
Contributor Author

stap-m commented Apr 13, 2026

@areleu @b-gehrke @amanda-wein @Ludee @schwarzatoffis please review and approve in case. Thanks!

Copy link
Copy Markdown
Contributor

@amanda-wein amanda-wein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this in Protege on my computer and it seems to work well. Much easier than having to manually reset the ID range each time I switch which ontology I'm working on! Thanks for setting this up 😄

@github-project-automation github-project-automation bot moved this from Review in progress to Reviewer approved in Issues Apr 14, 2026
@stap-m stap-m merged commit 796f479 into dev Apr 14, 2026
4 checks passed
@github-project-automation github-project-automation bot moved this from Reviewer approved to Done in Issues Apr 14, 2026
@stap-m stap-m deleted the feature-2223-id-ranges branch April 14, 2026 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

add developer id ranges

5 participants