Skip to content

Conversation

@NathanMOlson
Copy link

Changes to get all unit tests to compile. There should be no functional change.

This is my first step toward syncing with mapillary/main.

@smathermather
Copy link

smathermather commented Aug 19, 2025

Thanks! Will be useful to have tests working first as the first step.

Any reason this is tied to 357? Is that to ensure tests work again for 357?

@NathanMOlson
Copy link
Author

Any reason this is tied to 357? Is that to ensure tests work again for 357?

Because as far as I can tell, 357 is the latest known working version.

@smathermather
Copy link

smathermather commented Aug 20, 2025

Got it. Exactly the clarification I needed.. Happy to change the base branch to a branch off 357. Do you have a preferred name for that new branch?

Just created a branch to merge it into, as 357 would be live for anyone installing right now.

@smathermather smathermather changed the base branch from 357 to 357_test_patch August 20, 2025 02:03
@smathermather smathermather changed the base branch from 357_test_patch to 357_cleanup August 20, 2025 02:05
@smathermather smathermather merged commit 25675ed into OpenDroneMap:357_cleanup Aug 20, 2025
1 of 2 checks passed
@NathanMOlson
Copy link
Author

Just created a branch to merge it into, as 357 would be live for anyone installing right now.

Actually, ODM master is currently using OpenSfM 355 branch, so it should be safe to modify 357.

This situation is why I think we should use git hashes (or git tags) instead of branch names to specify dependency versions in ODM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants