Skip to content

Conversation

@glebm
Copy link

@glebm glebm commented Mar 24, 2023

These are patches for libmodplug that fix various UB issues. They come from these PRs to the upstream repository:

  1. Fix UB when calling cctype functions Konstanty/libmodplug#92
  2. avoid unaligned loads / stores Konstanty/libmodplug#93

The upstream maintainer has not merged any PRs in over a year.

Fixes #105.

These are patches for libmodplug that fix various UB issues.
They come from these PRs to the upstream repository:
1. Konstanty/libmodplug#92
2. Konstanty/libmodplug#93

The upstream maintainer has not merged any PRs in over a year.

Fixes OpenDingux#105.

Signed-off-by: Gleb Mazovetskiy <glex.spb@gmail.com>
@glebm glebm force-pushed the libmodplug-patches branch from 68f7be0 to 8a74499 Compare March 24, 2023 09:11
@pcercuei pcercuei merged commit 80a6c80 into OpenDingux:opendingux May 6, 2023
@pcercuei
Copy link
Member

pcercuei commented May 6, 2023

I'm tired of waiting for BR to merge the patches. So I'll just merge it now. Sorry if it took so long.

@glebm glebm deleted the libmodplug-patches branch May 6, 2023 13:27
@glebm
Copy link
Author

glebm commented Oct 13, 2023

They did finally merge one of the patches buildroot@33d0a13

I need to send them a follow-up with the rest of the patches

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Playing mod music files often results in a crash

2 participants