Merge main into v2 may 4 2026#112
Merged
jerrysxie merged 5 commits intoMay 4, 2026
Merged
Conversation
…ntity Data, executing Hard Reset (OpenDevicePartnership#104) Builds on OpenDevicePartnership/embedded-usb-pd#64 --------- Co-authored-by: Copilot <copilot@github.com>
Bumps `device-driver` from 1.0.3 to 1.0.9. - Updated `Cargo.toml` dependency declaration. - Refreshed `Cargo.lock` via `cargo build`. - Certified `device-driver` 1.0.9 as `safe-to-run` via cargo-vet. Co-authored-by: Felipe Balbi <febalbi@microsoft.com>
RobertZ2011
approved these changes
May 4, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Updates the driver and related tooling configuration, and adds support for reading/parsing additional USB-PD discovery registers (SVIDs + SOP/SOP′ identity), including async accessors and tests.
Changes:
- Bump
device-driver/device-driver-clito 1.0.9 and adjust supply-chain audit configuration. - Add register definitions + parsing/
TryFromconversions for Discovered SVIDs and Received SOP/SOP′ Identity Data. - Expose new async APIs to read those registers (internal + embassy wrapper) and update tests for upstream type changes.
Reviewed changes
Copilot reviewed 16 out of 19 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| supply-chain/config.toml | Removes an exemption entry for device-driver. |
| supply-chain/audits.toml | Adds audits for device-driver 1.0.9. |
| Cargo.toml | Bumps device-driver dependency to 1.0.9. |
| README.md | Updates device-driver-cli install version to 1.0.9. |
| .github/workflows/device-driver.yml | Updates CI generator to use device-driver-cli 1.0.9. |
| .github/copilot-instructions.md | Adds repo-specific PR review guidance for Copilot. |
| src/registers/mod.rs | Exposes new register modules. |
| src/registers/discovered_svids.rs | Adds Discovered SVIDs register implementation + tests. |
| src/registers/received_sop_identity_data.rs | Adds SOP identity register parsing + conversion + tests. |
| src/registers/received_sop_prime_identity_data.rs | Adds SOP′ identity register parsing + conversion + tests. |
| src/asynchronous/internal/mod.rs | Adds async methods to read the new registers. |
| src/asynchronous/embassy/mod.rs | Adds embassy wrapper methods for the new async APIs (+ HRST helper). |
| src/command/mod.rs | Adds HRST command variant + parsing + tests. |
| src/command/gcdm.rs | Updates Svid import path. |
| src/lib.rs | Updates test helpers to match embedded_usb_pd PDO type changes. |
| src/asynchronous/embassy/rx_caps.rs | Updates tests to use struct update syntax with Default. |
williampMSFT
approved these changes
May 4, 2026
jerrysxie
merged commit abe5568
into
OpenDevicePartnership:v0.2.0
29 of 30 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.