Update source/destination values of DIRECT_REQ2#69
Merged
Raymond-MS merged 1 commit intoMay 11, 2026
Merged
Conversation
…ification for FFA_MSG_SEND_DIRECT_REQ2. The source is the upper 16 bits while the destination is the lower 16 bits. Flipped them to the correct order.
Collaborator
Author
|
I was able to confirm that this change fixes the problem I was seeing on our reference SBSA platform. |
philgweber
approved these changes
May 8, 2026
Collaborator
philgweber
left a comment
philgweber
left a comment
There was a problem hiding this comment.
Thanks, I validated our EC services with this on SBSA.
kurtjd
approved these changes
May 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The source and destination IDs look to be backwards via the FF-A specification for FFA_MSG_SEND_DIRECT_REQ2. The source is the upper 16 bits while the destination is the lower 16 bits. Flipped them to the correct order.
See Section 15.4 of the FF-A spec:
https://developer.arm.com/documentation/den0077/o/?lang=en
How This Was Tested
N/A
Integration Instructions
N/A