Skip to content

feat: Battery service implementation + tests (all 15 opcodes) #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dymk wants to merge 8 commits into
base: main
Choose a base branch
from
+560 −37
Open

feat: Battery service implementation + tests (all 15 opcodes) #57

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
1a0472c
fix: use explicit host target for cargo test in pre-commit hook
dymk Apr 15, 2026
19b0807
feat(02-01): add Battery state struct and response types
dymk Apr 15, 2026
6df0a52
feat(02-01): implement all 15 battery opcode methods and wire dispatch
dymk Apr 15, 2026
d98e682
test(02-02): add 15 core battery opcode unit tests
dymk Apr 15, 2026
81e8976
test(02-02): add BTP/BMC round-trip edge cases and unknown command test
dymk Apr 15, 2026
e32619e
fix(02): use set_flag byte for BTP/BMC to allow zero-value writes
dymk Apr 15, 2026
4d32eca
fix: standardize remain_cap → remaining_cap naming
dymk Apr 15, 2026
8dd18e4
test: add BTP and BMC zero-value write round-trip tests
dymk Apr 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions .husky/pre-commit
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,11 +43,17 @@ check_rustup_target "aarch64-unknown-none"
set -x

# cargo deny --log-level=warn check
cargo clippy --target=aarch64-unknown-none -p ihv1-ec-sp -p qemu-ec-sp
cargo clippy
cargo clippy --target=aarch64-unknown-none -p ihv1-ec-sp -p qemu-ec-sp -- -D warnings
cargo clippy -- -D warnings
cargo fmt --check
cargo hack check --feature-powerset --exclude=ihv1-ec-sp --exclude=qemu-ec-sp
cargo hack check --feature-powerset --target=aarch64-unknown-none
cargo test -q
HOST_TARGET=$(rustc -vV | sed -n 's/host: //p')
if [ -z "$HOST_TARGET" ]; then
echo "Failed to determine Rust host target from \`rustc -vV\` output."
echo "Please verify that \`rustc -vV\` prints a valid \`host:\` line."
exit 1
fi
cargo test --target "$HOST_TARGET" -q
cd "$PROJECT_DIR/platform/qemu-sp" && cargo build --target=aarch64-unknown-none
cd "$PROJECT_DIR/platform/ihv1-sp" && cargo build --target=aarch64-unknown-none
Loading
Loading