Initialize dev-mcxa platform#12
Merged
Merged
Conversation
Contributor
tullom
commented
May 5, 2026
tullom
commented
- Add Cargo.toml for the dev-mcxa platform with dependencies for cortex-m, defmt, and embassy.
- Create build.rs to manage memory.x file for linker.
- Add VSCode workspace configuration for the dev-mcxa project.
- Implement Board struct for UART communication using embassy-mcxa.
- Create main.rs to initialize the platform and spawn UART service task.
- Implement UartAdapter to bridge embedded-io-async traits for UART communication.
- Add Cargo.toml for the dev-mcxa platform with dependencies for cortex-m, defmt, and embassy. - Create build.rs to manage memory.x file for linker. - Add VSCode workspace configuration for the dev-mcxa project. - Implement Board struct for UART communication using embassy-mcxa. - Create main.rs to initialize the platform and spawn UART service task. - Implement UartAdapter to bridge embedded-io-async traits for UART communication.
Cargo Vet Audit Passed
|
There was a problem hiding this comment.
Pull request overview
This PR brings up a new standalone platform/dev-mcxa firmware target so the codebase can run the existing mock ODP UART path on an MCXA-based board, alongside the existing dev platform crates.
Changes:
- Adds a new
dev-mcxacrate with target-specific Cargo, linker, and runner configuration. - Implements minimal board bring-up plus a UART adapter so
embassy-mcxacan drive the existinguart-service. - Adds editor configuration so the new platform can be opened and checked from VS Code/rust-analyzer.
Reviewed changes
Copilot reviewed 14 out of 15 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
platform/dev-mcxa/src/uart_adapter.rs |
Bridges embassy-mcxa UART APIs to the older embedded-io-async traits used by uart-service. |
platform/dev-mcxa/src/main.rs |
Adds the MCXA executor entrypoint, clock setup, mock relay init, and UART task spawn. |
platform/dev-mcxa/src/board.rs |
Defines the board-level UART peripheral initialization and pin wiring. |
platform/dev-mcxa/memory.x |
Declares the MCXA flash/RAM linker layout. |
platform/dev-mcxa/dev-mcxa.code-workspace |
Adds a per-platform VS Code workspace. |
platform/dev-mcxa/Cargo.toml |
Introduces the new standalone platform manifest and dependencies. |
platform/dev-mcxa/Cargo.lock |
Locks the dependency graph for the new platform crate. |
platform/dev-mcxa/build.rs |
Copies memory.x into OUT_DIR for linking. |
platform/dev-mcxa/.cargo/config.toml |
Configures the build target, linker flags, and probe-rs runner. |
.vscode/settings.json |
Registers the new platform manifest with shared rust-analyzer settings. |
felipebalbi
requested changes
May 5, 2026
- Updated embassy dependencies in Cargo.toml to pin to a specific git hash. - Increased RAM size in memory.x from 128K to 244K. - Refactored UART to use BBQ with DMA support. - Added clocks.rs for clock configuration management. - Adjusted main.rs to utilize the new clock configuration.
kurtjd
requested changes
May 6, 2026
kurtjd
reviewed
May 7, 2026
kurtjd
reviewed
May 7, 2026
felipebalbi
reviewed
May 7, 2026
tullom
force-pushed
the
init-dev-mcxa
branch
2 times, most recently
from
dc1b58f to
26195d5
Compare
Now that dev-mcxa builds cleanly, treat it like the other dev-*
targets across CI and docs.
- Add dev-mcxa to scripts/check-all.sh and mention it in README.md
and docs/supply-chain.md
- Enable the standard deny lints and bump to edition 2024
- Alias embedded-io{,-async} 0.6 and 0.7 as distinct packages and
switch the LPUART adapter to the 0.6 traits required by
uart-service
- Drop the 3 s startup delay and tidy clocks.rs imports
kurtjd
previously approved these changes
May 12, 2026
jerrysxie
previously requested changes
May 12, 2026
kurtjd
approved these changes
May 12, 2026
felipebalbi
approved these changes
May 12, 2026
felipebalbi
dismissed
jerrysxie’s stale review
embassy-executor changed behavior since RT6xx.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.