Skip to content

Derive PartialEq and Eq#66

Merged
RobertZ2011 merged 1 commit into
OpenDevicePartnership:mainfrom
RobertZ2011:derive-eq
May 13, 2026
Merged

Derive PartialEq and Eq#66
RobertZ2011 merged 1 commit into
OpenDevicePartnership:mainfrom
RobertZ2011:derive-eq

Conversation

@RobertZ2011
Copy link
Copy Markdown
Contributor

Add anything that got missed.

Add anything that got missed.
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds PartialEq/Eq derives across several UCSI/Type‑C data types that were previously missing them, enabling straightforward comparisons in tests and higher-level logic.

Changes:

  • Derive PartialEq and Eq for PPM command args and response types.
  • Derive PartialEq and Eq for UCSI and LPM response types plus select raw bitfield wrappers.
  • Derive PartialEq and Eq for type_c::ConnectionState.

Reviewed changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated no comments.

Show a summary per file
File Description
src/ucsi/ppm/ppm_reset.rs Adds PartialEq/Eq to ppm_reset::Args.
src/ucsi/ppm/mod.rs Adds PartialEq/Eq to PPM ResponseData and Response<T>.
src/ucsi/ppm/get_capability.rs Adds PartialEq/Eq to Args, PowerSourceRaw, and PowerSource.
src/ucsi/ppm/cancel.rs Adds PartialEq/Eq to cancel::Args.
src/ucsi/mod.rs Adds PartialEq/Eq to UCSI ResponseData, Response<T>, and command header types.
src/ucsi/lpm/mod.rs Adds PartialEq/Eq to LPM ResponseData, Response<T>, and ConnectorNumberRaw.
src/ucsi/lpm/get_error_status.rs Adds PartialEq/Eq to get_error_status::Args.
src/ucsi/lpm/get_connector_status.rs Adds PartialEq/Eq to ResponseDataRaw and Args.
src/ucsi/lpm/get_connector_capability.rs Adds PartialEq/Eq to get_connector_capability::Args.
src/type_c.rs Adds PartialEq/Eq to ConnectionState.

@RobertZ2011 RobertZ2011 marked this pull request as ready for review May 12, 2026 21:41
@RobertZ2011 RobertZ2011 requested a review from a team as a code owner May 12, 2026 21:41
@RobertZ2011 RobertZ2011 merged commit 0061a1e into OpenDevicePartnership:main May 13, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants