Derive PartialEq and Eq#66
Merged
Merged
Conversation
Add anything that got missed.
Contributor
There was a problem hiding this comment.
Pull request overview
Adds PartialEq/Eq derives across several UCSI/Type‑C data types that were previously missing them, enabling straightforward comparisons in tests and higher-level logic.
Changes:
- Derive
PartialEqandEqfor PPM command args and response types. - Derive
PartialEqandEqfor UCSI and LPM response types plus select raw bitfield wrappers. - Derive
PartialEqandEqfortype_c::ConnectionState.
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/ucsi/ppm/ppm_reset.rs | Adds PartialEq/Eq to ppm_reset::Args. |
| src/ucsi/ppm/mod.rs | Adds PartialEq/Eq to PPM ResponseData and Response<T>. |
| src/ucsi/ppm/get_capability.rs | Adds PartialEq/Eq to Args, PowerSourceRaw, and PowerSource. |
| src/ucsi/ppm/cancel.rs | Adds PartialEq/Eq to cancel::Args. |
| src/ucsi/mod.rs | Adds PartialEq/Eq to UCSI ResponseData, Response<T>, and command header types. |
| src/ucsi/lpm/mod.rs | Adds PartialEq/Eq to LPM ResponseData, Response<T>, and ConnectorNumberRaw. |
| src/ucsi/lpm/get_error_status.rs | Adds PartialEq/Eq to get_error_status::Args. |
| src/ucsi/lpm/get_connector_status.rs | Adds PartialEq/Eq to ResponseDataRaw and Args. |
| src/ucsi/lpm/get_connector_capability.rs | Adds PartialEq/Eq to get_connector_capability::Args. |
| src/type_c.rs | Adds PartialEq/Eq to ConnectionState. |
kurtjd
approved these changes
May 12, 2026
tullom
approved these changes
May 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add anything that got missed.