Update embedded-io and impl for unsplit UART#39
Merged
Merged
Conversation
kurtjd
requested review from
RobertZ2011,
felipebalbi,
jerrysxie and
tullom
as code owners
kurtjd
force-pushed
the
update-uart
branch
5 times, most recently
from
a32b704 to
a111ec5
Compare
Signed-off-by: Kurtis Dinelle <kdinelle@microsoft.com>
tullom
approved these changes
May 12, 2026
RobertZ2011
approved these changes
May 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update
embedded-io-asyncto v7 since that is what the uart-service now uses. Technically a breaking change, but don't know of anyone other than odp-embedded-controller using it. Will announce on Zulip to be safe though.Also implemented the trait for the unsplit Uart instance which resolves #37
Note: Had to make quite a few unrelated changes to get CI to pass since Cargo.lock was never originally checked in. So regenerated Cargo.lock (and remvoed it from .gitignore), fixed breaking changes, updated MSRV, and update the CI job to use the
--lockedflag. Also had to add the exception forbare-metalin deny.