Skip to content

Add embedded-io v7 impls for uart#561

Merged
kurtjd merged 1 commit into
OpenDevicePartnership:mainfrom
kurtjd:embedded-io-v7
May 13, 2026
Merged

Add embedded-io v7 impls for uart#561
kurtjd merged 1 commit into
OpenDevicePartnership:mainfrom
kurtjd:embedded-io-v7

Conversation

@kurtjd
Copy link
Copy Markdown
Contributor

@kurtjd kurtjd commented May 13, 2026

This adds embedded-io v7 trait implementations for uart to support the updated uart-service but keeps the existing v6 trait implementations to avoid introducing breaking changes to downstream consumers.

Resolves #560

Signed-off-by: Kurtis Dinelle <kdinelle@microsoft.com>
@kurtjd kurtjd self-assigned this May 13, 2026
Copilot AI review requested due to automatic review settings May 13, 2026 15:24
@kurtjd kurtjd requested a review from a team as a code owner May 13, 2026 15:24
@github-project-automation github-project-automation Bot moved this to In progress in ODP Backlog May 13, 2026
@kurtjd kurtjd moved this from In progress to In review in ODP Backlog May 13, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds embedded-io/embedded-io-async v0.7 (via aliased dependencies) trait implementations for the UART types, while keeping the existing v0.6 implementations to avoid breaking downstream users.

Changes:

  • Implement core::fmt::Display and core::error::Error for uart::Error.
  • Add embedded-io v0.7 and embedded-io-async v0.7 trait impls for Uart, UartRx, and UartTx (blocking + async).
  • Add aliased v0.7 dependencies and update lockfiles to include both v0.6 and v0.7 versions.

Reviewed changes

Copilot reviewed 2 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
src/uart.rs Adds Error formatting/Error trait impls and implements embedded-io/embedded-io-async v0.7 traits alongside existing v0.6 impls.
Cargo.toml Adds aliased dependencies for embedded-io v0.7 and embedded-io-async v0.7.
Cargo.lock Records the additional v0.7 embedded-io dependencies in the workspace lockfile.
examples/rt685s-evk/Cargo.lock Updates example lockfile to include v0.7 embedded-io dependencies.
examples/rt633/Cargo.lock Updates example lockfile to include v0.7 embedded-io dependencies.

@kurtjd kurtjd merged commit f3be03c into OpenDevicePartnership:main May 13, 2026
15 checks passed
@github-project-automation github-project-automation Bot moved this from In review to Done in ODP Backlog May 13, 2026
@kurtjd kurtjd deleted the embedded-io-v7 branch May 13, 2026 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Add embedded-io-async v7 impls to uart

4 participants