Skip to content

Bump device-driver to 1.0.9#25

Merged
felipebalbi merged 1 commit into
OpenDevicePartnership:mainfrom
felipebalbi:update-device-driver
Apr 29, 2026
Merged

Bump device-driver to 1.0.9#25
felipebalbi merged 1 commit into
OpenDevicePartnership:mainfrom
felipebalbi:update-device-driver

Conversation

@felipebalbi
Copy link
Copy Markdown
Contributor

@felipebalbi felipebalbi commented Apr 29, 2026

Bumps device-driver from 1.0.3 to 1.0.9.

  • Updated Cargo.toml dependency declaration.
  • Refreshed Cargo.lock via cargo build.
  • Re-formatted src/device.rs with nightly rustfmt to satisfy the nightly / fmt check (the file was previously committed in raw device-driver-cli output, which doesn't match the unstable rustfmt.toml options used by the nightly fmt job).
  • Fixed .github/workflows/device-driver.yml: the device-driver-pregen-check job previously diffed raw device-driver-cli output against the committed file. Once the committed file is nightly-formatted, that comparison is structurally guaranteed to break (and vice versa). The workflow now installs nightly with rustfmt and runs rustup run nightly rustfmt --edition 2024 ci_gen_device.rs between the generate and diff steps, so the comparison happens on equivalently-formatted code.
  • Verified locally: nightly fmt-check, cargo clippy -- -F clippy::suspicious -F clippy::correctness -F clippy::perf -F clippy::style, cargo build, cargo test, and the new CI flow simulated end-to-end (regen → nightly rustfmt → byte-identical diff).

Copilot AI review requested due to automatic review settings April 29, 2026 13:18
@felipebalbi felipebalbi requested a review from a team as a code owner April 29, 2026 13:18
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Bumps the Rust device-driver dependency to 1.0.9, updating both the manifest and lockfile to ensure builds resolve the intended crate version.

Changes:

  • Updated Cargo.toml to require device-driver 1.0.9 (with default-features = false unchanged).
  • Refreshed Cargo.lock to reflect device-driver 1.0.9 and its new checksum.

Reviewed changes

Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.

File Description
Cargo.toml Bumps the device-driver dependency requirement to 1.0.9.
Cargo.lock Updates the resolved device-driver package entry to 1.0.9 (version + checksum).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@felipebalbi felipebalbi force-pushed the update-device-driver branch from 4a7a705 to 46372bf Compare April 29, 2026 14:03
Copilot AI review requested due to automatic review settings April 29, 2026 14:09
@felipebalbi felipebalbi force-pushed the update-device-driver branch from 46372bf to f5a70ca Compare April 29, 2026 14:09
@felipebalbi
Copy link
Copy Markdown
Contributor Author

This one is odd. If I just generate the file cargo fmt fails, if I cargo fmt, then device-driver-pregen-check will fail. @tullom, what do you prefer here?

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 3 changed files in this pull request and generated 1 comment.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread Cargo.toml
@felipebalbi
Copy link
Copy Markdown
Contributor Author

This one is odd. If I just generate the file cargo fmt fails, if I cargo fmt, then device-driver-pregen-check will fail. @tullom, what do you prefer here?

I'm assuming we want both format and device-driver-pregen passing. Updating CI accordingly.

Updates the `device-driver` dependency from 1.0.3 to 1.0.9 and refreshes
Cargo.lock (resolved 1.0.7 -> 1.0.9 transitively). No cargo-vet config
present in this repo, so no audit certification is needed.

Assisted-by: Claude:claude-opus-4.7
@felipebalbi felipebalbi force-pushed the update-device-driver branch from f5a70ca to 2b9dbb1 Compare April 29, 2026 14:35
@felipebalbi felipebalbi enabled auto-merge (squash) April 29, 2026 14:35
@felipebalbi felipebalbi merged commit 6ecbf6a into OpenDevicePartnership:main Apr 29, 2026
10 checks passed
@felipebalbi felipebalbi deleted the update-device-driver branch April 29, 2026 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants