fix KBChunker recursive chunker initialization error#478
Merged
ZhaoyangHan04 merged 2 commits intoOpenDCAI:mainfrom Feb 27, 2026
Merged
fix KBChunker recursive chunker initialization error#478ZhaoyangHan04 merged 2 commits intoOpenDCAI:mainfrom
ZhaoyangHan04 merged 2 commits intoOpenDCAI:mainfrom
Conversation
ZhaoyangHan04
approved these changes
Feb 27, 2026
Contributor
ZhaoyangHan04
left a comment
ZhaoyangHan04
left a comment
There was a problem hiding this comment.
Thanks for pointing out this Chunker usage error. This should be due to insufficient unittests. We will keep on working it. Appreciate it!
Collaborator
|
Sorry for missing this earlier — the group messages were a bit overwhelming, and we overlooked it. Thanks for the reminder, and the PR has already been merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a bug fix which I 've already mentioned in WeChat Group.
Refer to Chonkie doc:
Chonkie
as the doc specified, recursive chunker doesn't take parameter "chunk_overlap" when initialize, it will cause error like "unexpected parameter" and fail the operator.
The change apply to both batch script and non-batch script of kbc-chunk-generator.