Skip to content

Fix index out of bounds for asynchrone SteadyStateFilter with estimat… #439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
erikpelgrim merged 2 commits into from
Dec 8, 2025
Merged

Fix index out of bounds for asynchrone SteadyStateFilter with estimat… #439

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bc01b77
Fix index out of bounds for asynchrone SteadyStateFilter with estimat…
erikpelgrim Dec 3, 2025
af6759e
Improve logging #436
erikpelgrim Dec 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions algorithms/java/src/org/openda/algorithms/kalmanFilter/SteadyStateFilter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -325,6 +325,7 @@ class HKCalculator {
private final String[] availableObsGainVectorIdArray;
private final HashMap<String, IVector> gainVectors;
ArrayList<Integer> missingObservationIndices = new ArrayList<>();
ArrayList<String> missingObservationGainVectorIds = new ArrayList<>();
ArrayList<Integer> availableObservationIndicesGainStorage = new ArrayList<>();
ArrayList<Integer> availableObservationIndicesObserver = new ArrayList<>();
private int numberOfMissingObservations;
Expand All @@ -350,6 +351,7 @@ private void fillIndicesArrays() {
}
System.out.printf("Observation for %s missing%n", gainVectorId);
this.missingObservationIndices.add(i);
this.missingObservationGainVectorIds.add(gainVectorId);
}
}

Expand Down Expand Up @@ -395,14 +397,13 @@ private void compensateForMissingObservationsWithHK(double[] obsTimeOffsets, IVe
for (int i = 0; i < this.missingObservationIndices.size(); i++) {
Integer missingObservationIndex = this.missingObservationIndices.get(i);
String missingObservationId = gainStorageObservationIdsArray[missingObservationIndex];
// Use relative time stamps in ids to distinguish between observations for asynchronous filtering
String gainVectorId = missingObservationId + ":" + Math.round(obsTimeOffsets[i] * 24.0 * 3600.0); //conversion to seconds
String gainVectorId = missingObservationGainVectorIds.get(i);
Results.putProgression("processing obs " + gainVectorId + "\n");
// add to analysis increment for this obs
if (this.gainVectors.containsKey(gainVectorId)) {
IVector gainVector = this.gainVectors.get(gainVectorId);
double calculatedInnovation = dMissing.getValue(i, 0);
System.out.println("Calculated innovation for " + missingObservationId + ": " + calculatedInnovation + " index in dMissing: " + i);
System.out.println("Estimated innovation for " + missingObservationId + ": " + calculatedInnovation + " index in dMissing: " + i);
delta.axpy(calculatedInnovation, gainVector);
}
}
Expand Down
Loading