Update thrift to 0.11 #143
Conversation
Update jars, add Thrift executable
nielsdrost
left a comment
nielsdrost
left a comment
There was a problem hiding this comment.
Nice work @erikpelgrim , thanks!
I'm a bit in doubt as to what we should do with the windows-only thrift compiler. I'm inclined to leave it like this.
Would it be an idea to also add a "build-using-system-thrift" target that uses the system-installed thrift? That way I can use it under linux too, though I'll have to bew carefull of the thrift version.
model_bmi/build_thrift.xml
Outdated
| <echo>Generating ${output_language} code in ${output_dir} using thrift code from ${input_file}</echo> | ||
| <exec executable="thrift" failonerror="${failonerror}"> | ||
| <arg line="-out ${output_dir}"/> | ||
| <exec executable="${resourcesdir}\thrift\thrift-0.11.0.exe" failonerror="${failonerror}"> |
There was a problem hiding this comment.
This only works under Windows. However, it does solve the versioning problem with thrift. @nilsvanvelzen what do you think?
Make windows only thrift build a separate ant task
|
I made a separate "build-windows-only" ant task and let the original as is (can be used on linux). I looked into also creating a linux-only task but the set of thrift files was 18 mb and I did not see an easy "plug and play" option like the windows executable. Therefore I decided to keep the original build target and make the "windows-only" an addition for windows dummies like me. |
|
Hello @erikpelgrim, I'm trying out the build on Linux, and I think we need an additional dependency in the thrift build "javax.annotation.version=1.3.2" to make it success on Java 11. Which java version do you normally use? |
|
Hi Niels,
For OpenDA I still use java 8, will this addition be compatible with Java 8 as well?
Regards,
Erik
From: Niels Drost <notifications@github.com>
Sent: maandag 15 juni 2020 17:30
To: OpenDA-Association/OpenDA <OpenDA@noreply.github.com>
Cc: Erik Pelgrim <Erik.Pelgrim@deltares.nl>; Mention <mention@noreply.github.com>
Subject: Re: [OpenDA-Association/OpenDA] Update thrift to 0.11 (#143)
Hello @erikpelgrim<https://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Ferikpelgrim&data=02%7C01%7C%7Cebed3b227e54441d85b908d81140f155%7C15f3fe0ed7124981bc7cfe949af215bb%7C0%7C1%7C637278317906028143&sdata=GSpfhOaoorSfDZa4ZUVYeVcpT9nEUtdHX3D7rC87KdM%3D&reserved=0>, I'm trying out the build on Linux, and I think we need an additional dependency in the thrift build "javax.annotation.version=1.3.2" to make it success on Java 11. Which java version do you normally use?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<https://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FOpenDA-Association%2FOpenDA%2Fpull%2F143%23issuecomment-644205294&data=02%7C01%7C%7Cebed3b227e54441d85b908d81140f155%7C15f3fe0ed7124981bc7cfe949af215bb%7C0%7C1%7C637278317906028143&sdata=2IA9w7nM8%2BqCHRSFvKwz%2BFwID6Db09UUMIOWstvNX9U%3D&reserved=0>, or unsubscribe<https://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAJOI7TK5WNHCPW5TSIFPSL3RWY46XANCNFSM4M3KYGNA&data=02%7C01%7C%7Cebed3b227e54441d85b908d81140f155%7C15f3fe0ed7124981bc7cfe949af215bb%7C0%7C1%7C637278317906028143&sdata=HR40T%2F7DbjVFzFPdFxTFh0n4gTCH8U2in6%2BZMtQh2ZU%3D&reserved=0>.
DISCLAIMER: This message is intended exclusively for the addressee(s) and may contain confidential and privileged information. If you are not the intended recipient please notify the sender immediately and destroy this message. Unauthorized use, disclosure or copying of this message is strictly prohibited. The foundation 'Stichting Deltares', which has its seat at Delft, The Netherlands, Commercial Registration Number 41146461, is not liable in any way whatsoever for consequences and/or damages resulting from the improper, incomplete and untimely dispatch, receipt and/or content of this e-mail.
|
|
Note that the latest versions of Java 8 cannot be used without a license by non-developers. |
Updated thrift jars
Added thrift 0.11 executable
Updated build_thrift.xml accordingly