ci(npm): disable publish lifecycle scripts#90
Open
BunsDev wants to merge 1 commit into
Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Hardens the npm publish GitHub Actions workflow by preventing npm lifecycle scripts from running during publish, mitigating the risk of NODE_AUTH_TOKEN exfiltration.
Changes:
- Add
--ignore-scriptsto scoped packagenpm publishinvocation. - Add
--ignore-scriptsto unscoped packagenpm publishinvocation.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
262
to
+266
| prepare_package "$package_name" | ||
| if [[ "$package_name" == @*/* ]]; then | ||
| (cd npm && npm publish --access public --provenance) | ||
| (cd npm && npm publish --access public --provenance --ignore-scripts) | ||
| else | ||
| (cd npm && npm publish --provenance) | ||
| (cd npm && npm publish --provenance --ignore-scripts) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
NODE_AUTH_TOKENinto the publish step and rannpm publishwithout disabling lifecycle scripts, allowing release-controlledprepublishOnly/prepare/prepackscripts to read or exfiltrate the token.Description
--ignore-scriptsto bothnpm publishinvocations in.github/workflows/npm-publish.ymlto prevent checked-out release package lifecycle scripts from executing withNODE_AUTH_TOKEN, while preserving provenance and publish behavior.Testing
git diff --checkand a local dry-run by adding maliciousprepublishOnly/prepack/preparescripts to a temp copy ofnpm/package.jsonthen executingNODE_AUTH_TOKEN=POC_NPM_TOKEN_123 npm publish --dry-run --ignore-scripts --foreground-scripts --access publicand verified the scripts did not run and no token leakage occurred.Codex Task