fix(ci): validate release workflow version input#86
Closed
BunsDev wants to merge 1 commit into
Closed
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Pull request overview
Adds early validation for the workflow_dispatch version input in the Release workflow, and standardizes use of a RELEASE_VERSION env var throughout the workflow to reduce repetition and prevent malformed tags from progressing through the pipeline.
Changes:
- Introduces a
RELEASE_VERSIONworkflow env var derived frominputs.version. - Adds a preflight step to validate the version string format before running other release steps.
- Sets
persist-credentials: falseon checkout steps and switches downstream tag usage toRELEASE_VERSION.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+40
to
+42
| if [[ ! "$RELEASE_VERSION" =~ ^v[0-9]+\.[0-9]+\.[0-9]+(-[0-9A-Za-z.-]+)?$ ]]; then | ||
| echo "::error::Version must be a v-prefixed SemVer tag, for example v0.1.0." | ||
| exit 1 |
Comment on lines
+54
to
56
| if git ls-remote --exit-code --tags origin "refs/tags/$RELEASE_VERSION" >/dev/null 2>&1; then | ||
| echo "::error::Tag $RELEASE_VERSION already exists" | ||
| exit 1 |
Member
Author
|
Closing — all changes from this PR (version input validation, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add validation for the version input in the release workflow to catch malformed tags early.