fix(cli): protect built-in TUI agent modes#84
Closed
BunsDev wants to merge 1 commit into
Closed
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Pull request overview
This PR hardens the CLI TUI agent-mode switcher so the reserved built-in modes (build, plan, explore) always resolve to the built-in agent definitions, preventing repository settings.json agents from shadowing those security-significant modes.
Changes:
- Added
resolve_tui_agent_mode()to give built-in TUI modes precedence over project-defined agents with the same name. - Updated the interactive TUI agent-mode change handler to use the new resolver.
- Added unit tests to ensure reserved modes ignore project overrides while non-reserved modes still resolve project agents.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+1278
to
+1284
| if let Some(def) = claurst_core::default_agents().get(mode) { | ||
| return Some(def.clone()); | ||
| } | ||
|
|
||
| let mut all_agents = claurst_core::coven_shared::default_agents_with_familiars(); | ||
| all_agents.extend(config_agents.clone()); | ||
| all_agents.get(mode).cloned() |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Protect built-in TUI agent modes from being overridden or shadowed.