Open
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #66 +/- ##
============================================
- Coverage 91.28% 89.16% -2.13%
- Complexity 155 156 +1
============================================
Files 29 29
Lines 551 572 +21
Branches 11 11
============================================
+ Hits 503 510 +7
- Misses 37 51 +14
Partials 11 11 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #65
IdpConfigurationneeds to provide keyStore password to shared configuration, or else wrong password will be used if configuredNow, that last bit got me the most cringing. Whoever wrote SAML JKSKeyManager should be fully ashamed of themselves for not making it flexible enough to source passwords from some other place but just a map of passwords. The only other way to fix this (given the implementation), is to recreate the JKS key manager every time there is a new entity, but then we'll need to keep the password map locally. Let me know if you'd like me to change that bit.