fix null block | basic 1.21.3 support#1
Open
Hackerjef wants to merge 1 commit intoOpenCommunity-Original:masterfrom
Open
fix null block | basic 1.21.3 support#1Hackerjef wants to merge 1 commit intoOpenCommunity-Original:masterfrom
Hackerjef wants to merge 1 commit intoOpenCommunity-Original:masterfrom
Conversation
|
I got same issue. Please merge @Envel-Nikita-Gutsenkov |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While this is a hotfix, this does fix the crashing that has been happening with 1.21.1+ users as noted in spigot page
Error that happens without the null check:
I'm assuming minecraft can't have a null block so it rather kick the client out instead of silently rejecting. Has to be a bug further up the chain but this helps with what i'm looking at. Maybe instead of not sending the block at all, all null/unknown blocks should be set to
minecraft:air