refactor: avoid QKeyCombination warnings on Qt6#1079
refactor: avoid QKeyCombination warnings on Qt6#1079kaamui merged 1 commit intoOpenBoard-org:devfrom
Conversation
|
This looks like a good solution for the warnings. I find the code more readable now too. |
https://github.com/OpenBoard-org/OpenBoard/blob/dev/src/core/UBShortcutManager.cpp#L599-L605 Not directly related, but why aren't there |
The |
bbf87c3 to
a514007
Compare
a514007 to
0ddd01d
Compare
- Qt6 introduced a new class QKeyCombination - in Qt5, a simple int was used - use the proper functions for each Qt version in UBShortcutManager
0ddd01d to
16c48b7
Compare
This PR is an attempt to fix #1077. See there for a discussion of the problem.