update error msg for user name change#1320
Conversation
| console.error(e) | ||
| reset() | ||
| toast.error('Unexpected error. Please try again.') | ||
| toast.error(e instanceof Error ? e.message : 'Unexpected error. Please try again.') |
There was a problem hiding this comment.
So does this correctly show an error message of Must wait 14 days to change username, instead of the unhelpful Unexpected Error message?
I see this issue on the backend, but it seems to me the 14 day wait is intentional, and this error message is the only thing that needs fixing. Should we close that backend issue, or am I missing something?
One thing that doesn't make sense to me is that I went to the deployment for this PR, and I was able to change the username several times in a row. I dont' see how this code change bypasses the 14 day limit 🤔
cc @mikeschen
There was a problem hiding this comment.
This is the FE component of the ticket.
I just put out PR for BE here: OpenBeta/openbeta-graphql#463
|
Backend deployed |
3 participants
name: Pull request
about: Create a pull request
title: ''
labels: ''
assignees: ''
What type of PR is this?(check all applicable)
Description
Go to Edit Profile
Go to Username
Change username
Click Save
Go to change name again
See error msg (must wait 14 days)
Related Issues
Issue #460 (in OpenBeta repo)
What this PR achieves
Screenshots, recordings
Notes