Skip to content

fix: resolve model ID input field accepting only single character #73

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rollroyces wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: resolve model ID input field accepting only single character #73

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 5 additions & 6 deletions ui/src/components/settings/view/tabs/PilotDeckConfigTab.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -692,7 +692,7 @@ function ProviderCard({
const protocol = provider.protocol ?? catalogEntry?.protocol ?? 'openai';
const effectiveUrl = provider.url || catalogEntry?.defaultUrl || '';
const enabledModels = Object.keys(provider.models ?? {});
const [newModelId, setNewModelId] = useState('');
const newModelInputRef = useRef<HTMLInputElement>(null);
const [providerIdDraft, setProviderIdDraft] = useState(providerId);
const [providerIdError, setProviderIdError] = useState('');
const displayName = providerDisplayName(
Expand Down Expand Up @@ -727,7 +727,7 @@ function ProviderCard({
if (!id) return;
if (provider.models && id in provider.models) return;
update({ models: { ...(provider.models ?? {}), [id]: {} } });
setNewModelId('');
if (newModelInputRef.current) newModelInputRef.current.value = '';
};
const removeModel = (mid: string) => {
const next = { ...(provider.models ?? {}) };
Expand Down Expand Up @@ -902,13 +902,12 @@ function ProviderCard({
{/* Add custom model */}
<div className="flex items-center gap-2">
<input
value={newModelId}
onChange={(e) => setNewModelId(e.target.value)}
ref={newModelInputRef}
placeholder={t('pilotDeckConfig.panels.models.customModelPlaceholder')}
className="min-w-0 flex-1 rounded-md border border-border bg-background px-2 py-1 font-mono text-[11px] text-foreground outline-none focus:ring-1 focus:ring-ring"
onKeyDown={(e) => { if (e.key === 'Enter' && !isImeEnterEvent(e)) addModel(newModelId); }}
onKeyDown={(e) => { if (e.key === 'Enter' && !isImeEnterEvent(e)) addModel(e.currentTarget.value); }}
/>
<Button variant="outline" size="sm" className="shrink-0" onClick={() => addModel(newModelId)} disabled={!newModelId.trim()}>
<Button variant="outline" size="sm" className="shrink-0" onClick={() => addModel(newModelInputRef.current?.value ?? '')} disabled={!(newModelInputRef.current?.value?.trim())}>
<Plus className="mr-1 h-3 w-3" />
{t('pilotDeckConfig.actions.add')}
</Button>
Expand Down