Skip to content

fix(dev-launcher): make npm run dev work on Windows #118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Fronut wants to merge 1 commit into
base: main
Choose a base branch
from
+11 −2
Open

fix(dev-launcher): make npm run dev work on Windows #118

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions scripts/dev-launcher.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,10 +119,19 @@ async function main() {
PILOTDECK_SKIP_DEFAULT_PROJECT: '1',
};

// On Windows the npm executable is a `npm.cmd` shim. Recent Node.js releases
// refuse to spawn `.cmd`/`.bat` files without a shell (they throw EINVAL, a
// hardening change from CVE-2024-27980), and the bare `npm` name cannot be
// resolved by `spawn` at all (ENOENT). Launch through the platform shell on
// Windows so `npm run dev` works out of the box; other platforms keep the
// plain, shell-free spawn. The arguments here are fixed literals with no
// user input, so enabling the shell carries no injection risk.
const isWindows = process.platform === 'win32';
const npmCommand = isWindows ? 'npm.cmd' : 'npm';
const child = spawn(
'npm',
npmCommand,
['--workspace', 'ui', 'run', 'dev:concurrent'],
{ cwd: repoRoot, env, stdio: 'inherit' },
{ cwd: repoRoot, env, stdio: 'inherit', shell: isWindows },
);

const forward = (signal) => {
Expand Down