fix(read_file): normalize empty pages string to prevent validation loop#114
Open
Gucc111 wants to merge 1 commit into
Open
fix(read_file): normalize empty pages string to prevent validation loop#114Gucc111 wants to merge 1 commit into
Gucc111 wants to merge 1 commit into
Conversation
When some models/providers emit `pages: ""` instead of omitting the field, parsePdfPageRange rejects it and triggers invalid_tool_input. After 3 consecutive failures the agent_tool_error_loop circuit breaker terminates the session. Treat blank pages values the same as omitted before validation runs. Closes OpenBMB#108 Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pagesvalues (""," ") to omitted before validation inread_file, preventinginvalid_tool_inputrejections that lead toagent_tool_error_looptermination.pages: ""instead of omitting the optional field for non-PDF files;parsePdfPageRangerejects the empty string, and after 3 consecutive failures the circuit breaker kills the session.Closes #108
Changes
src/tool/builtin/readFile.ts— added 4 lines invalidateInputbefore the existingpagescheck:Test plan
read_filewithpages: ""on a non-PDF file no longer returnsinvalid_tool_inputread_filewithpages: "1-5"on a PDF still works correctlytsc --noEmitpasses with no type errorsMade with Cursor