Allow custom HTTP Client in SDK#96
Merged
rickyrombo merged 2 commits intomainfrom Jan 14, 2026
Merged
Conversation
raymondjacobson
approved these changes
Jan 14, 2026
|
|
||
| uploads := []*Upload{} | ||
| ss.crud.DB.Where("template = 'audio' and status in ?", []string{newStatus, busyStatus, errorStatus}).Find(&uploads) | ||
| // Only select uploads that have a CID set to avoid race condition with TUS uploads |
Contributor
There was a problem hiding this comment.
just confirming that there's no other chances where orig file cid can be null?
Contributor
Author
There was a problem hiding this comment.
Even if there was, there'd be no way for the transcoder to transcode as it wouldn't be able to fetch the content.
raymondjacobson
pushed a commit
that referenced
this pull request
Feb 6, 2026
* Allow custom httpo client in SDK * prevent transcode jobs from trying to run on incomplete uploads
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Needed this to be able to set some TLS settings for local dev. Separately, also found that it was keeping me from using the SDK to do downloads/streams as it would time out after 30s.
Probably makes more sense to use the SDK as each individual piece... like the timeout/http client should probably be different for the Mediorum service vs core... so maybe not the right approach here and we should initialize the different clients separately on the consumer side?
Thoughts?