Skip to content

fix(core): coerce nil ProverAddresses in finalizeStorageProof to unstick prod chain #313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
raymondjacobson merged 1 commit into from
May 26, 2026
+9 −1
Merged

fix(core): coerce nil ProverAddresses in finalizeStorageProof to unstick prod chain #313

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion pkg/core/server/pos.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -298,14 +298,22 @@ func (s *Server) finalizeStorageProof(ctx context.Context, tx *v1.SignedTransact

proofSigStr := base64.StdEncoding.EncodeToString(sp.ProofSignature)

// pgx serializes a nil slice as SQL NULL, which violates the NOT NULL
// constraint on storage_proofs.prover_addresses and aborts the
// FinalizeBlock transaction — halting the chain.
proverAddresses := sp.ProverAddresses
if proverAddresses == nil {
proverAddresses = []string{}
}

if err := qtx.InsertStorageProof(
ctx,
db.InsertStorageProofParams{
BlockHeight: sp.Height,
Address: sp.Address,
Cid: pgtype.Text{String: sp.Cid, Valid: true},
ProofSignature: pgtype.Text{String: proofSigStr, Valid: true},
ProverAddresses: sp.ProverAddresses,
ProverAddresses: proverAddresses,
},
); err != nil {
return nil, fmt.Errorf("could not persist storage proof in db: %v", err)
Expand Down
Loading