Skip to content

fix(mediorum): case-insensitive access authority check #203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rickyrombo wants to merge 4 commits into
base: main
Choose a base branch
from
Open

fix(mediorum): case-insensitive access authority check #203

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5a38c20
fix(mediorum): make access authority check case-insensitive
rickyrombo Apr 10, 2026
dceccd0
fix(mediorum): normalize address in Go before SQL query to preserve i…
Copilot Apr 10, 2026
4788740
fix(mediorum): normalize management_keys address in Go to preserve in…
Copilot Apr 10, 2026
b152e61
fix(core): normalize access authority addresses to lowercase on insert
rickyrombo Apr 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pkg/core/server/manage_entity.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ func (s *Server) processTrackManageEntity(ctx context.Context, me *v1.ManageEnti
for _, addr := range signers {
if err := q.InsertManagementKey(ctx, db.InsertManagementKeyParams{
TrackID: trackID,
Address: addr,
Address: strings.ToLower(addr),
}); err != nil {
return fmt.Errorf("insert management_key: %w", err)
}
Expand Down
4 changes: 0 additions & 4 deletions pkg/etl/go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,14 +31,10 @@ require (
github.com/jackc/puddle/v2 v2.2.1 // indirect
github.com/lib/pq v1.10.9 // indirect
github.com/mmcloughlin/addchain v0.4.0 // indirect
github.com/stretchr/testify v1.11.1 // indirect
github.com/supranational/blst v0.3.13 // indirect
go.opentelemetry.io/otel/metric v1.40.0 // indirect
go.opentelemetry.io/otel/trace v1.40.0 // indirect
go.uber.org/atomic v1.7.0 // indirect
go.uber.org/multierr v1.11.0 // indirect
golang.org/x/crypto v0.44.0 // indirect
golang.org/x/net v0.47.0 // indirect
golang.org/x/sys v0.40.0 // indirect
golang.org/x/text v0.31.0 // indirect
rsc.io/tmplfunc v0.0.3 // indirect
Expand Down
4 changes: 2 additions & 2 deletions pkg/etl/go.sum
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,8 +146,8 @@ github.com/prometheus/procfs v0.15.1 h1:YagwOFzUgYfKKHX6Dr+sHT7km/hxC76UB0leargg
github.com/prometheus/procfs v0.15.1/go.mod h1:fB45yRUv8NstnjriLhBQLuOUt+WW4BsoGhij/e3PBqk=
github.com/rivo/uniseg v0.2.0 h1:S1pD9weZBuJdFmowNwbpi7BJ8TNftyUImj/0WQi72jY=
github.com/rivo/uniseg v0.2.0/go.mod h1:J6wj4VEh+S6ZtnVlnTBMWIodfgj8LQOQFoIToxlJtxc=
github.com/rogpeppe/go-internal v1.13.1 h1:KvO1DLK/DRN07sQ1LQKScxyZJuNnedQ5/wKSR38lUII=
github.com/rogpeppe/go-internal v1.13.1/go.mod h1:uMEvuHeurkdAXX61udpOXGD/AzZDWNMNyH2VO9fmH0o=
github.com/rogpeppe/go-internal v1.14.1 h1:UQB4HGPB6osV0SQTLymcB4TgvyWu6ZyliaW0tI/otEQ=
github.com/rogpeppe/go-internal v1.14.1/go.mod h1:MaRKkUm5W0goXpeCfT7UZI6fk/L7L7so1lCWt35ZSgc=
github.com/shirou/gopsutil v3.21.4-0.20210419000835-c7a38de76ee5+incompatible h1:Bn1aCHHRnjv4Bl16T8rcaFjYSrGrIZvpiGO6P3Q4GpU=
github.com/shirou/gopsutil v3.21.4-0.20210419000835-c7a38de76ee5+incompatible/go.mod h1:5b4v6he4MtMOwMlS0TUMTu2PcXUg8+E1lC7eC3UO/RA=
github.com/stretchr/objx v0.1.0/go.mod h1:HFkY916IF+rwdDfMAkV7OtwuqBVzrE8GR6GFx+wExME=
Expand Down
6 changes: 4 additions & 2 deletions pkg/mediorum/server/serve_blob.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -526,7 +526,8 @@ func (s *MediorumServer) requireRegisteredSignature(next echo.HandlerFunc) echo.
// If track has access_authorities (management_keys), ONLY those signers may authorize - not validator keys
if trackID != "" && managementKeyCount > 0 {
var count int
s.crud.DB.Raw("SELECT COUNT(*) FROM management_keys WHERE track_id = ? AND address = ?", trackID, sig.SignerWallet).Scan(&count)
normalizedSignerWallet := strings.ToLower(sig.SignerWallet)
s.crud.DB.Raw("SELECT COUNT(*) FROM management_keys WHERE track_id = ? AND address = ?", trackID, normalizedSignerWallet).Scan(&count)
if count == 0 {
Comment on lines 526 to 531
Copy link

Copilot AI Apr 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are existing unit tests for requireRegisteredSignature, but none cover the access_authorities/management_keys path with mixed-case addresses. Add a test where the stored management_keys.address casing differs from the signer wallet (checksummed vs lowercase) to ensure this regression stays fixed.

Copilot uses AI. Check for mistakes.
s.logger.Debug("sig no match (access_authorities)", zap.String("signed by", sig.SignerWallet), zap.String("track_id", trackID))
return c.JSON(401, map[string]string{
Expand Down Expand Up @@ -685,7 +686,8 @@ func (ss *MediorumServer) serveTrack(c echo.Context) error {
}

var count int
ss.crud.DB.Raw("SELECT COUNT(*) FROM management_keys WHERE track_id = ? AND address = ?", trackId, sig.SignerWallet).Scan(&count)
normalizedSignerWallet := strings.ToLower(sig.SignerWallet)
ss.crud.DB.Raw("SELECT COUNT(*) FROM management_keys WHERE track_id = ? AND address = ?", trackId, normalizedSignerWallet).Scan(&count)
if count == 0 {
ss.logger.Debug("sig no match", zap.String("signed by", sig.SignerWallet))
return c.JSON(401, map[string]string{
Expand Down
4 changes: 3 additions & 1 deletion pkg/mediorum/server/serve_blob_grpc.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ import (
"context"
"errors"
"io"
"strings"
"time"

"connectrpc.com/connect"
Expand Down Expand Up @@ -44,7 +45,8 @@ func (s *MediorumServer) streamTrackGRPC(ctx context.Context, req *v1storage.Str
}

var count int
s.crud.DB.Raw("SELECT COUNT(*) FROM management_keys WHERE track_id = ? AND address = ?", trackId, ethAddress).Scan(&count)
normalizedEthAddress := strings.ToLower(ethAddress)
s.crud.DB.Raw("SELECT COUNT(*) FROM management_keys WHERE track_id = ? AND address = ?", trackId, normalizedEthAddress).Scan(&count)
if count == 0 {
s.logger.Debug("sig no match", zap.String("signed by", ethAddress))
return connect.NewError(connect.CodePermissionDenied, errors.New("signer not authorized to access"))
Expand Down
Loading