replace conda: parameter with conda_packages:

[zacharyburnett]

alternative to #361

replace the conda: parameter (which invoked the now-archived tox-conda) with conda_packages:.

If the user populates conda_packages then the workflow sets up a Mamba environment that tox runs within.

To migrate from tox-conda, copy conda_deps from tox.ini to conda_packages in the test workflow, and then also remember to list any non-Python Conda packages in allowlist_externals:

allowlist_externals =
    hstcal

this will require a major version bump

[zacharyburnett]

@pllim this should hopefully be a good way forward instead of using tox-conda; please let me know your thoughts. I don't think this should go into 3.0.0 at the moment, probably 4.0.0 eventually

[pllim]

Ooo thanks! Is there a way to test with this branch over at https://github.com/spacetelescope/wfc3tools ?

[zacharyburnett]

Yes! Just make a PR that changes this line:
https://github.com/spacetelescope/wfc3tools/blob/f0eaea52a6f233c9238d45b2dcfc42a1f326a395/.github/workflows/tests.yml#L25

-    uses: OpenAstronomy/github-actions-workflows/.github/workflows/tox.yml@2835f0cacddf3f8de198db9afdb5354a5cebe0ef  # v2.6.3
+    uses: zacharyburnett/github-actions-workflows/.github/workflows/tox.yml@install_conda_packages_directly

[zacharyburnett]

here: spacetelescope/wfc3tools#119

[zacharyburnett]

actually @Cadair if we can squeeze another PR into the 3.0.0 release, this one seems to be working well

[zacharyburnett]

wait no never mind, I still need to use matrix.conda_packages instead of inputs.conda_packages

[zacharyburnett]

ok, fixed

[zacharyburnett]

tested at https://github.com/spacetelescope/wfc3tools/actions/runs/26904804618

[Cadair]

This let's you install binaries for use in tox but not libraries right? You couldn't import a package installed like this?

[Cadair]

Given how this is separate from tox, I wonder if it would be best folded into libraries like the system package managers?

[zacharyburnett]

Oh that's a good idea!

[zacharyburnett]

actually on second thought, maybe we should keep them separate; the conda environment is distinct from the runner and platform, and you can install both

[Cadair]

I'm still not entirely sure what the limits of this functionality are so hard to judge. Can you use this to install C libraries and have them picked up inside tox?

[Cadair]

I'm in no mad rush for 3.0 fwiw, so happy to get this in.

[codecov-commenter]

⚠️ Please install the to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 66.66%. Comparing base (e113052) to head (7747782).
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #391   +/-   ##
=======================================
  Coverage   66.66%   66.66%           
=======================================
  Files           2        2           
  Lines           6        6           
=======================================
  Hits            4        4           
  Misses          2        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.