A very quick implementation of fail on labels#91
Draft
Cadair wants to merge 1 commit into
Draft
Conversation
Cadair
force-pushed
the
fail_on_label
branch
from
b542880 to
57a97f5
Compare
Contributor
|
Would be nice to show example config file with |
bsipocz
approved these changes
Oct 17, 2019
Member
bsipocz
left a comment
bsipocz
left a comment
There was a problem hiding this comment.
looks good to me, just minor comments
| @@ -0,0 +1,37 @@ | |||
| from loguru import logger | |||
|
|
||
| from baldrick.plugins.github_pull_requests import pull_request_handler | ||
|
|
||
| BLOCKED_MESSAGE = 'This pull request is blocked from being merged by labels.' |
Member
There was a problem hiding this comment.
could we have the name of the label, that triggered this, listed, too?
Member
There was a problem hiding this comment.
Or all of them that triggers this in a repo? (I don't expect all maintainers to always know about this feature)
| pass_message = bl_config.get("label_absent_message", MERGEABLE_MESSAGE) | ||
|
|
||
| pr_labels = set(pr_handler.labels) | ||
| blocking_labels = set(cl_config.get('labels', []) |
Member
There was a problem hiding this comment.
Suggested change
| blocking_labels = set(cl_config.get('labels', []) | |
| blocking_labels = set(cl_config.get('blocking_labels', []) |
to remove ambiguity
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@bsipocz
Fixes #90