Skip to content

[WIP] Enable auto installation ID lookup#57

Open
pllim wants to merge 1 commit into
OpenAstronomy:masterfrom
pllim:auto-id
Open

[WIP] Enable auto installation ID lookup#57
pllim wants to merge 1 commit into
OpenAstronomy:masterfrom
pllim:auto-id

Conversation

@pllim
Copy link
Copy Markdown
Contributor

@pllim pllim commented Dec 9, 2018

Fix #46 . Do you even want to go this route before I have to worry about updating the rest of tests?

  • Fix test failures
  • Add change log

@astrofrog
Copy link
Copy Markdown
Collaborator

I guess one issue is that it would be nice to also be able to use some parts of the GitHub API without authentication. I wonder whether we should specifically say that installation='auto' or installation=True to mean automatically get the ID? @Cadair do you have any thoughts?

@Cadair
Copy link
Copy Markdown
Member

Cadair commented Aug 23, 2019

I think this looks fine to me.

This doesn't stop us from creating a repo handler for a non-installed repo and doing things that aren't authenticated right?

@pllim
Copy link
Copy Markdown
Contributor Author

pllim commented Aug 23, 2019

I don't even remember this one anymore... 😬 Let me know if I should revisit this, or we can just close this...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Better way to provide installation ID when running bot locally

3 participants