Skip to content

DEBUG: Print out which repo#113

Open
pllim wants to merge 1 commit into
OpenAstronomy:masterfrom
pllim:debug-reponame
Open

DEBUG: Print out which repo#113
pllim wants to merge 1 commit into
OpenAstronomy:masterfrom
pllim:debug-reponame

Conversation

@pllim
Copy link
Copy Markdown
Contributor

@pllim pllim commented Apr 6, 2021

As suggested in #111 (comment)

@pllim pllim requested a review from Cadair April 6, 2021 15:17
@codecov-io
Copy link
Copy Markdown

Codecov Report

Merging #113 (41ecbff) into master (cf93ea5) will decrease coverage by 4.27%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #113      +/-   ##
==========================================
- Coverage   83.22%   78.94%   -4.28%     
==========================================
  Files          17       17              
  Lines         930      931       +1     
==========================================
- Hits          774      735      -39     
- Misses        156      196      +40     
Impacted Files Coverage Δ
baldrick/blueprints/github.py 100.00% <100.00%> (ø)
baldrick/plugins/github_towncrier_changelog.py 39.28% <0.00%> (-47.62%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cf93ea5...41ecbff. Read the comment docs.

@pllim
Copy link
Copy Markdown
Contributor Author

pllim commented Apr 6, 2021

Eh... How did this one print statement break the code?


        sys.platform.startswith('win'),
        reason='process_towncrier_changelog returns failure on Windows')
    def test_changelog_type_substring(self, app):
    
        self.get_file_contents.return_value = CUSTOM_TYPE_TEMPLATE
        self.modified_files.return_value = (['changelog/1234.docfix.rst'])
    
        with app.app_context():
>           messages = process_towncrier_changelog(self.pr_handler, self.repo_handler)

../../.tox/py38-test/lib/python3.8/site-packages/baldrick/plugins/tests/test_github_towncrier_changelog.py:88: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
../../.tox/py38-test/lib/python3.8/site-packages/baldrick/plugins/github_towncrier_changelog.py:130: in process_towncrier_changelog
    config = load_towncrier_config(pr_handler)
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 

pr_handler = <baldrick.github.github_api.PullRequestHandler object at 0x7fe467d89790>

    def load_towncrier_config(pr_handler):
        file_content = pr_handler.get_file_contents("pyproject.toml", branch=pr_handler.base_branch)
        config = loads(file_content)
        if "towncrier" in config.get("tool", {}):
>           return parse_toml(config)
E           TypeError: parse_toml() missing 1 required positional argument: 'config'

../../.tox/py38-test/lib/python3.8/site-packages/baldrick/plugins/github_towncrier_changelog.py:105: TypeError

@pllim
Copy link
Copy Markdown
Contributor Author

pllim commented Apr 6, 2021

Failure is caused by #105

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants