Graceful handling when dpfile parameter is missing in cid2xml#54
Open
Jackkal wants to merge 1 commit intoOpenAWE-Project:masterfrom
Open
Graceful handling when dpfile parameter is missing in cid2xml#54Jackkal wants to merge 1 commit intoOpenAWE-Project:masterfrom
Jackkal wants to merge 1 commit intoOpenAWE-Project:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a graceful handling when the dpfile is not given as argument in cid2xml, but a dp resource is expected by the cid class. The dpfile argument is optional since not all cid classes require a dp resource, but the cid2xml core dumped when a dp resource was expected by the specific cid class, but not given as argument to cid2xml.
Before:
$cid2xml cid_taskdefinition.bin
Segmentation fault (core dumped)
After:
$cid2xml cid_taskdefinition.bin
Error: /code/OpenAWE/src/awe/objectbinaryreadstream.cpp:36: dp file expected but not defined